Skip to content

Commit

Permalink
Trying to make tests more robusts
Browse files Browse the repository at this point in the history
  • Loading branch information
martinboulais committed Feb 20, 2025
1 parent 89ae2f9 commit 235b23f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions test/public/qcFlags/forDataPassCreation.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ module.exports = () => {
await pressElement(page, '#row49-ITS-text .select-multi-flag');
await pressElement(page, '#row49-ITS-text .select-multi-flag');

await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await waitForNavigation(page, () => pressElement(page, '#set-qc-flags-trigger'));

// Runs are ordered by run number
Expand All @@ -251,7 +251,7 @@ module.exports = () => {
await pressElement(page, '#row54-ITS-text .select-multi-flag');
await pressElement(page, '#row56-ITS-text .select-multi-flag');

await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await waitForNavigation(page, () => pressElement(page, '#set-qc-flags-trigger'));

await expectInnerText(page, 'div.panel.flex-grow.items-center > div > em', 'The selected runs don\'t have overlapping start/stop times');
Expand All @@ -263,7 +263,7 @@ module.exports = () => {
await pressElement(page, '#row54-ITS-text .select-multi-flag');
await pressElement(page, '#row49-ITS-text .select-multi-flag');

await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await waitForNavigation(page, () => pressElement(page, '#set-qc-flags-trigger'));

await expectInnerText(
Expand All @@ -280,7 +280,7 @@ module.exports = () => {
await pressElement(page, '#row56-FT0-text .select-multi-flag');
await pressElement(page, '#row54-ITS-text .select-multi-flag');

await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await waitForNavigation(page, () => pressElement(page, '#set-qc-flags-trigger'));

await page.waitForSelector('button#submit[disabled]');
Expand Down
8 changes: 4 additions & 4 deletions test/public/runs/runsPerDataPass.overview.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ module.exports = () => {
const targetFileName = 'runs.json';

// First export
await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await pressElement(page, '#export-runs-trigger');
await page.waitForSelector('#export-runs-modal');
await page.waitForSelector('#send:disabled');
Expand Down Expand Up @@ -468,10 +468,10 @@ module.exports = () => {
});

it('should successfully not display button to discard all QC flags for the data pass', async () => {
await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
const popoverSelector = await getPopoverSelector(await page.waitForSelector('#actions-dropdown-button .popover-trigger'));
await page.waitForSelector(`${popoverSelector} button:nth-child(3)`, { hidden: true });
await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
});

it('should successfully discard all QC flags for the data pass', async () => {
Expand All @@ -485,7 +485,7 @@ module.exports = () => {
await setConfirmationDialogToBeAccepted(page);
const popoverSelector = await getPopoverSelector(await page.waitForSelector('#actions-dropdown-button .popover-trigger'));
// Press again actions dropdown to re-trigger render
await pressElement(page, '#actions-dropdown-button');
await pressElement(page, '#actions-dropdown-button .popover-trigger', true);
await pressElement(page, `${popoverSelector} button:nth-child(3)`, true);
await waitForTableLength(page, 3);
await expectInnerText(page, '#row106-CPV-text', 'QC'); // Expect QC flag button to be there
Expand Down

0 comments on commit 235b23f

Please sign in to comment.