Attempt at improving balloon randomly failing tests

AliceO2Group · Feb 21, 2025 · 2a38cbd · 2a38cbd
1 parent 5d9f1bf
commit 2a38cbd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/test/public/defaults.js b/test/public/defaults.js
@@ -517,7 +517,7 @@ const getPopoverContent = (popoverTrigger) => {
         }
 
         const popover = document.querySelector(`.popover[data-popover-key="${key}"]`);
-        return popover.innerHTML;
+        return popover.innerText;
     });
 };
 
@@ -558,11 +558,17 @@ module.exports.getPopoverInnerText = getPopoverInnerText;
  */
 module.exports.checkColumnBalloon = async (page, rowIndex, columnIndex) => {
     const popoverTrigger = await page.waitForSelector(`tbody tr:nth-of-type(${rowIndex}) td:nth-of-type(${columnIndex}) .popover-trigger`);
-    const triggerContent = await popoverTrigger.evaluate((element) => element.querySelector('.w-wrapped').innerHTML);
+    const triggerContent = await popoverTrigger.evaluate((element) => element.querySelector('.w-wrapped').innerText);
 
-    const actualContent = await getPopoverContent(popoverTrigger);
+    await page.hover(`tbody tr:nth-of-type(${rowIndex}) td:nth-of-type(${columnIndex}) .popover-trigger`);
+    const popoverSelector = await this.getPopoverSelector(popoverTrigger);
 
-    expect(triggerContent).to.be.equal(actualContent);
+    await this.expectInnerTextTo(
+        page,
+        popoverSelector,
+        // Newlines may be inconsistent between balloon and original data
+        (popoverContent) => popoverContent.replaceAll('\n', '') === triggerContent.replaceAll('\n', ''),
+    );
 };
 
 /**

diff --git a/test/public/runs/overview.test.js b/test/public/runs/overview.test.js
@@ -267,8 +267,6 @@ module.exports = () => {
     it('Should have balloon on detector, tags and eor column', async () => {
         await goToPage(page, 'run-overview');
 
-        await pressElement(page, '#openFilterToggle');
-
         // Run 106 has detectors and tags that overflow
         await fillInput(page, filterPanelRunNumbersInputSelector, '106', ['change']);
         await waitForTableLength(page, 1);