Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1290] Fix run detectors selection in runs per data-pass overview #1865

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Fixed de-selection of runs/detectors in runs per datapass

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.62%. Comparing base (aa10960) to head (235b23f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ib/public/views/Runs/RunDetectorsSelectionModel.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
+ Coverage   44.44%   44.62%   +0.17%     
==========================================
  Files        1011     1011              
  Lines       16980    16981       +1     
  Branches     3052     3053       +1     
==========================================
+ Hits         7547     7577      +30     
+ Misses       9433     9404      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xsalonx
xsalonx previously approved these changes Feb 19, 2025
xsalonx
xsalonx previously approved these changes Feb 20, 2025
@martinboulais martinboulais merged commit 2b56788 into main Feb 20, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1290/fix-runs-detector-selection branch February 20, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants