Fix ASCII encoding issue when updating files with non-ASCII characters (#116)

* Fix ASCII encoding issue when updating files with non-ASCII characters

* move test to intg

* bump to 0.2.12

---------

Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: Hoang Tran <descience.thh10@gmail.com>

Author: 3 people

openhands_aci/editor/encoding.py

@@ -48,6 +48,10 @@ def detect_encoding(self, path: Path) -> str:
         # Get the best match if any exists
         if results and results['confidence'] > self.confidence_threshold:
             encoding = results['encoding']
+            # Always use utf-8 instead of ascii for text files to support non-ASCII characters
+            # This ensures files initially containing only ASCII can later accept non-ASCII content
+            if encoding.lower() == 'ascii':
+                encoding = self.default_encoding
         else:
             encoding = self.default_encoding
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "openhands-aci"
-version = "0.2.11"
+version = "0.2.12"
 description = "An Agent-Computer Interface (ACI) designed for software development agents OpenHands."
 authors = ["OpenHands"]
 license = "MIT"

tests/integration/test_oh_editor.py

@@ -356,6 +356,26 @@ def test_insert_with_empty_string(editor):
     assert len(content) == 3  # Original 2 lines plus empty line
 
 
+def test_insert_chinese_text_into_english_file(editor):
+    editor, test_file = editor
+    result = editor(
+        command='insert',
+        path=str(test_file),
+        insert_line=0,
+        new_str='中文文本',
+    )
+    assert isinstance(result, CLIResult)
+    assert '中文文本' in test_file.read_text()
+    assert (
+        result.output
+        == f"""The file {test_file} has been edited. Here's the result of running `cat -n` on a snippet of the edited file:
+     1\t中文文本
+     2\tThis is a test file.
+     3\tThis file is for testing purposes.
+Review the changes and make sure they are as expected (correct indentation, no duplicate lines, etc). Edit the file again if necessary."""
+    )
+
+
 def test_insert_with_none_new_str(editor):
     editor, test_file = editor
     with pytest.raises(EditorToolParameterMissingError) as exc_info: