Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer IsAssociatedChannel and IsValidHeadstage #2343

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Prefer IsAssociatedChannel and IsValidHeadstage #2343

merged 3 commits into from
Feb 4, 2025

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Jan 29, 2025 •
edited
Loading

This makes the code clearer.

  • Check with fresh eyes again

Close #2212

@t-b t-b self-assigned this Jan 29, 2025
@t-b t-b force-pushed the feature/2343-prefer-better-functions-for-headstage-checking branch from 0fcaf1c to 3423a36 Compare February 3, 2025 12:43
@t-b
Copy link
Collaborator Author

t-b commented Feb 3, 2025

Will merge once CI passes.

@t-b t-b force-pushed the feature/2343-prefer-better-functions-for-headstage-checking branch from 3423a36 to 9345430 Compare February 3, 2025 18:25
@t-b t-b merged commit afa1072 into main Feb 4, 2025
23 checks passed
@t-b t-b deleted the feature/2343-prefer-better-functions-for-headstage-checking branch February 4, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use IsValidHeadstage in all places instead of IsNaN/IsFinite/...
1 participant
@t-b