Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHI_Checkinstallation #2367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CHI_Checkinstallation #2367

wants to merge 1 commit into from

Conversation

MichaelHuth
Copy link
Collaborator

requires #2364
closes #1857

@MichaelHuth MichaelHuth force-pushed the feature/2367-mh_update_checkinstallation branch from ba59d4d to 4fc33fd Compare March 10, 2025 12:33
@t-b
Copy link
Collaborator

t-b commented Mar 11, 2025

I'm getting this output

•chi_checkInstallation()
  Checking system properties:
  Igor 64bit: 9.06, 56704
  Microsoft Windows 11 Pro (24H2)
  ASLR: False (Nice!)
  
Checking known defines:
  DEBUGGING_ENABLED: No
  EVIL_KITTEN_EATING_MODE: No
  BACKGROUND_TASK_DEBUGGING: No
  THREADING_DISABLED: No
  
Checking base installation:
  Mies version info: Valid "Release_2.8_20240925-280-g0e00a14b3..." (Nice!)
  Installation with hardware: False
  JSON XOP: Found version 1.0.0.1 (Nice!)
  ZeroMQ XOP: Found version 1.0.0.1 (Nice!)
  TUF XOP: Found version 1.0.0.1 (Nice!)
  MiesUtils XOP: Found version 1.0.0.1 (Nice!)
  NWBv2 compound XOP: Found version 1.0.0.1 (Nice!)
  JSON XOP: Present in the right version (version-892-g9251933) (Nice!)
  ITC2 XOP: Present in the wrong version (expected: latest-174-gb9915a9 vs present: error querying version) (Very Bad)
  TUF XOP: Present in the right version (version-163-g686effb) (Nice!)
  Results: 7 checks, 1 number of errors
  
Checking extended installation:
  Results: 0 checks, 0 number of errors

for a user installation without hardware. I would expect no errors. Please also output a small section with the info from the installer json log.

@t-b t-b assigned MichaelHuth and unassigned t-b Mar 11, 2025
@MichaelHuth
CHI: CheckInstallation is now aware of the installation configuration…
1688b79 
… saved

In a previous commit the installer saves now information on the configuration.
This is now evaluated by CHI_CheckInstallation and the output is adapted accordingly.
XOPs required for hardware support are not checked if the installation was without hardware.
@MichaelHuth MichaelHuth force-pushed the feature/2367-mh_update_checkinstallation branch from 4fc33fd to 1688b79 Compare March 12, 2025 14:46
@MichaelHuth
Copy link
Collaborator Author

Made a section for installation config report.

Removed check for ITC2 XOP if not installed with HW.

@MichaelHuth MichaelHuth assigned t-b and unassigned MichaelHuth Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@t-b t-b Awaiting requested review from t-b t-b is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CHI_CHeckInstallation output correct information for installations without hardware
2 participants
@MichaelHuth @t-b