Add fail_if_missing flag to ensure source data exists #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheriferson
reviewed
Jun 21, 2024
Comment on lines
+83
to
+89
| if not is_object(source_path) and not is_folder(source_path): | ||
| message = f"S3 path {source_path} does not exist as object or folder" | ||
| if self.config.fail_if_missing: | ||
| raise FileNotFoundError(message) | ||
| self.logger.warning(message) | ||
| return | ||
|
|
There was a problem hiding this comment.
Mostly for my curiosity, when would we want this behavior when fail_if_missing is False?
sheriferson
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Change?
fail_if_missingflag) to fail explicitly if source data does not exist. this is configurable.Testing
note that these tests will fail until AllenInstitute/aibs-informatics-core#5 is merged