Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save metadata as json creates badly formatted json #423

Closed
toloudis opened this issue Feb 11, 2025 · 2 comments · Fixed by #451
Closed

save metadata as json creates badly formatted json #423

toloudis opened this issue Feb 11, 2025 · 2 comments · Fixed by #451
Assignees

Comments

@toloudis
Copy link

Select multiple rows in Variance dataset, for example.
Right click --> Save Metadata As --> JSON
"Select All" to get all metadata columns.

When you examine the json file, you will see that the individual rows are just dumped one by one with newlines, which is not actually valid JSON.

They really should be wrapped with [] and comma separated to be a proper json list, or wrapped in a json object somehow.

@toloudis toloudis added the bug label Feb 11, 2025
@SeanLeRoy
Copy link
Contributor

Hmm strange the underlying csv library we use handles this so I'd assumed it was just working with JSON. I'll take a look, is this relevant for the Vol-E features?

@toloudis
Copy link
Author

I was looking into it for experimenting with VolE integration stuff, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants