Add simple query argument input #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
commented
Mar 10, 2025
There was a problem hiding this comment.
This file has actual code changes
SeanLeRoy
commented
Mar 10, 2025
There was a problem hiding this comment.
This file has actual code changes (an added test)
aswallace
reviewed
Mar 10, 2025
| sources: unparsedURLs.map((uri) => ({ | ||
| uri, | ||
| ...getNameAndTypeFromSourceUrl(uri), | ||
| })), |
There was a problem hiding this comment.
If there are other params present will they be ignored? e.g., http://localhost:9001/app?url=https://biofile-finder-datasets.s3.us-west-2.amazonaws.com/Variance%20Paper%20Dataset.csv&group=Cell+Line
There was a problem hiding this comment.
Yea - for more complex stuffs they'll need to use the other system (or maybe we can add on later TBD)
aswallace
approved these changes
Mar 10, 2025
This is just for simple use case like maybe another app wants to send their dataset to us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The query arguments for BFF are fairly complex which is necessary for the amount of customization we allow via URL sharing however it would be nice to be able to supply just a simplified version of it for when you just need to share a BFF link to a dataset which is what this does. Also included in this is the renaming of the entity FileExplorerURL -> SearchParams which felt more accurate. I tagged the two files where there are actual code changes.
Resolves #436
Testing
Tested running locally like so:
http://localhost:9001/app?url=https://biofile-finder-datasets.s3.us-west-2.amazonaws.com/Variance%20Paper%20Dataset.csv