Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider aics/redux-utils dependency #463

Open
aswallace opened this issue Mar 7, 2025 · 0 comments
Open

Reconsider aics/redux-utils dependency #463

aswallace opened this issue Mar 7, 2025 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@aswallace
Copy link
Contributor

aswallace commented Mar 7, 2025

Context

We currently depend on @aics/redux-utils for our redux state management and testing utilities. Current developers on this project no longer remember why we use our own package rather than an externally maintained one.

This impacts our other dependencies, since @aics/redux-utils uses certain core dependencies (axios, typescript, redux, react) that are set to versions that haven't been updated in a couple years. This prevents our updating to more recent versions of those packages (see #461 ).

Suggestions

We have 3 options:

  1. Leave things as they are, and continue using potentially out-of-date core dependencies
  2. Re-start maintaining @aics/redux-utils
  3. Switch to an externally maintained package like redux-toolkit

Issues with 2:

  • We should make sure we know why we originally started using it
  • Will take some unknown amount of time/effort to keep maintaining it (could be little or could be a lot)
  • Do we know if other AICS packages use it, and if so, how many?

Issues with 3:

  • Will likely involve more significant changes across the whole BFF codebase to match our redux usage to the current standard
@aswallace aswallace added the dependencies Pull requests that update a dependency file label Mar 7, 2025
@SeanLeRoy SeanLeRoy self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants