Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to delete fields from edit modal #465

Open
aswallace opened this issue Mar 7, 2025 · 2 comments
Open

Ability to delete fields from edit modal #465

aswallace opened this issue Mar 7, 2025 · 2 comments
Assignees

Comments

@aswallace
Copy link
Contributor

aswallace commented Mar 7, 2025

Use Case

Our work so far on the edit modal only allows users to add or edit metadata fields, not remove them completely

Suggest a Solution

Unsure if we need extra UX work on this or if the existing interface can be modified to allow deletions

Relates to #96

@lynwilhelm
Copy link
Collaborator

lynwilhelm commented Mar 10, 2025

A couple thoughts/proposal ideas @aswallace @SeanLeRoy

  • I assume deleting isn’t something we want to encourage loudly
  • Thinking delete should happen more deeply into the edit flow (not as an initial option)
  • Aren’t there some metadata fields we’d want to restrict from deleting? If so, we could “disable” the delete link and offer a tooltip saying cannot delete.
  • I'm still noodling on the final delete modal
  • Actually not sure if "back" is more appropriate or "cancel" and we just close the modal

This is my first riff so lemme know thoughts please:)

Image
Image

@SeanLeRoy
Copy link
Contributor

I assume deleting isn’t something we want to encourage loudly

We don't need to hide it or anything - but it doesn't need to be like super obvious I suppose

Aren’t there some metadata fields we’d want to restrict from deleting? If so, we could “disable” the delete link and offer a tooltip saying cannot delete.

In your current workflow they wouldn't get to the delete option since it wouldn't be selectable from the dropdown list. Instead, it would be a disable option in the dropdown with a tooltip that says "Not editable" or something

Actually not sure if "back" is more appropriate or "cancel" and we just close the modal

🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants