Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Intel chip MacOS support #449

Merged
merged 3 commits into from
Feb 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/manual-build.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ on:
- ubuntu-latest
- windows-latest
- macos-latest
- macos-13

jobs:
build:
@@ -43,4 +42,4 @@ jobs:
name: electron-build-${{ github.event.inputs.os }}
path: |
packages/desktop/build
retention-days: 7 # Artifacts will be stored for 7 days
retention-days: 7 # Artifacts will be stored for 7 days
14 changes: 0 additions & 14 deletions dev-docs/04-versioning-and-deployment.md
Original file line number Diff line number Diff line change
@@ -46,20 +46,6 @@ builds of `packages/desktop`, prepare a draft Github release, and upload the bui
mark whether the release is "pre-release." If it is marked as "pre-release," it will not be accessible for download through the
Github pages site.

<!-- Added by Brian W 2025-02-18 -->
7) **Temporary workaround for MacOS Intel Chipsets (as of Feb 2025):**
GitHub Actions currently builds .dmg files that don't work for x86 processors and that are interpreted as "damaged" by new MacOS versions. The primary recommendation for building executables for Intel chipsets on MacOS is now to use the [manual-build](https://github.com/AllenInstitute/biofile-finder/actions/workflows/manual-build.yml) GitHub Action. This workflow automatically generates .dmg files for x86 architectures. To build the x86 version, ensure that you select the macOS-13 runner environment in the workflow, which is configured specifically for x86 builds. After the workflow completes, download, unzip and rename the .dmg file to include the current tag number and the target processor.

If additional customization is needed or if you encounter issues with the workflow, you can use the fallback option locally:
<!-- Added by Anya W 2025-01-07 -->
Navigate to the `packages/desktop` directory and run:
```
npm run build-executable
```
This command creates a build directory containing an install file (e.g., BioFile Finder-tag.number.dmg). After the build completes, rename the .dmg file to include the current tag number and the target processor (for example, BioFile Finder-tag.number-arm64.dmg or BioFile Finder-tag.number-x86_64.dmg), and upload the file to the release page. If GitHub has already generated .dmg files automatically, you may need to delete them before uploading your build.



### Development Builds for Specific Branches

You can generate development builds from any branch using the [manual-build](https://github.com/AllenInstitute/biofile-finder/actions/workflows/manual-build.yml) GitHub Action. Select the branch from the dropdown in the GitHub Action interface and choose the appropriate runner environment from the following options: