(Tiny) Fix JSON formatting for metadata downloads #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswallace
changed the title
SeanLeRoy
approved these changes
Feb 26, 2025
kmitcham
approved these changes
Feb 26, 2025
| @@ -38,7 +38,8 @@ export default class DatabaseServiceWeb extends DatabaseService { | |||
| } | |||
|
|
|||
| const resultName = `${destination}.${format}`; | |||
| const finalSQL = `COPY (${sql}) TO '${resultName}' (FORMAT '${format}');`; | |||
| const formatOptions = format === "json" ? ", ARRAY true" : ""; | |||
| const finalSQL = `COPY (${sql}) TO '${resultName}' (FORMAT '${format}'${formatOptions});`; | |||
There was a problem hiding this comment.
I'm suspicious that there should be a space (or some other character) between FORMAT '${format}' and ${formatOptions} but don't actually know if that is a problem.
There was a problem hiding this comment.
I left it out since I stuck a comma + space in formatOptions instead so that if there's nothing there it can just be (FORMAT format)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
"Save metadata as JSON" was creating improperly formatted JSON files (used new lines instead of array format)
closes #423
Changes
Adds DuckDB's format option to the SQL
Testing
Manually tested by downloading JSON files from the Variance dataset, and verified that csv and parquet still work correctly