Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Tiny) Fix JSON formatting for metadata downloads #451

Merged
merged 1 commit into from
Feb 26, 2025
Merged

(Tiny) Fix JSON formatting for metadata downloads #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/web/src/services/DatabaseServiceWeb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export default class DatabaseServiceWeb extends DatabaseService {
}

const resultName = `${destination}.${format}`;
const finalSQL = `COPY (${sql}) TO '${resultName}' (FORMAT '${format}');`;
const formatOptions = format === "json" ? ", ARRAY true" : "";
const finalSQL = `COPY (${sql}) TO '${resultName}' (FORMAT '${format}'${formatOptions});`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspicious that there should be a space (or some other character) between FORMAT '${format}' and ${formatOptions} but don't actually know if that is a problem.

Copy link
Contributor Author

@aswallace aswallace Feb 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it out since I stuck a comma + space in formatOptions instead so that if there's nothing there it can just be (FORMAT format)

const connection = await this.database.connect();
try {
await connection.send(finalSQL);
Expand Down