bugfix/empty-local-path #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
reviewed
Mar 5, 2025
| @@ -6,7 +6,7 @@ export default { | |||
| FILE_NAME: "file_name", // a file attribute (top-level prop on file documents in MongoDb) | |||
| FILE_SIZE: "file_size", // a file attribute (top-level prop on file documents in MongoDb) | |||
| FILE_PATH: "file_path", // a file attribute (top-level prop on file documents in MongoDb) | |||
| LOCAL_FILE_PATH: "File Path (Local VAST)", // (optional) annotation for FMS files on the local NAS | |||
| LOCAL_FILE_PATH: "file_local_path", // (optional) annotation for FMS files on the local NAS | |||
There was a problem hiding this comment.
I don't understand the need for this? When does "File Path (Local VAST)" come into play?
| @@ -110,6 +101,7 @@ export default class FileDetail { | |||
| this.fileDetail = fileDetail; | |||
| this.env = env; | |||
| this.uniqueId = uniqueId; | |||
| this.fileDetail.file_local_path = this.localPath; | |||
There was a problem hiding this comment.
Why are we changing the inner fileDetail here?
| if (this.path.startsWith("/allen")) { | ||
| return this.path; | ||
| if (this.downloadInProgress) { | ||
| return "Copying to VAST in progress…"; |
| @@ -211,7 +188,7 @@ export default class FileDetail { | |||
|
|
|||
| public get downloadInProgress(): boolean { | |||
| const shouldBeInLocal = this.getFirstAnnotationValue(AnnotationName.SHOULD_BE_IN_LOCAL); | |||
| return Boolean(shouldBeInLocal) && !this.getLocalPath(); | |||
| return Boolean(shouldBeInLocal) && !this.getAnnotation("Cache Eviction Date"); | |||
There was a problem hiding this comment.
Looks like now that it is used a couple places "Cache Eviction Date" should be added to AnnotationName and used like a constant
| } | ||
| //// | ||
|
|
||
| if (this.getAnnotation("Cache Eviction Date")) { | ||
| return this.getLocalPath(); |
There was a problem hiding this comment.
Can we just move the body of the getLocalPath function in here? Feels funky that there are two localPath functions.
Like so:
const cloudPrefix = `${AICS_FMS_S3_URL_PREFIX}${AICS_FMS_S3_BUCKETS[this.env]}`;
if (this.getAnnotation("Cache Eviction Date") && this.path.startsWith(cloudPrefix)) {
const localPrefix = NAS_HOST_PREFIXES[this.env];
const relativePath = this.path.replace(`${cloudPrefix}`, "");
return `${localPrefix}${relativePath}`;
}
return null;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
Testing