-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/metadata editing/restrict annotations #464
Open
SeanLeRoy
wants to merge
14
commits into
feature/metadata-editing/develop
Choose a base branch
from
feature/metadata-editing/restrict-annotations
base: feature/metadata-editing/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
81a3a18
Add password form
SeanLeRoy e9d980c
Simplify fetch for file details
SeanLeRoy 4612a91
Clean up; Use hook for grabbing selection
SeanLeRoy 6913786
Simplify data flow
SeanLeRoy b6821a5
Add common loading icon styled correctly
SeanLeRoy 0b746e8
Add dropdown and lookup as viable annotation types
SeanLeRoy 17a3f41
Use loading icon
SeanLeRoy 867b21d
Bury details of immutability in backend specific context
SeanLeRoy 458fe62
Expose error from fetching details
SeanLeRoy f292be9
Use the same component for loading icons
SeanLeRoy 5661047
WIP
SeanLeRoy 8e654df
Merge branch 'feature/metadata-editing/develop' into feature/metadata…
SeanLeRoy 36045a5
Merge fixes
SeanLeRoy 0382131
Add remaining programs
SeanLeRoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Before merging - test putting this into a file we can request from the web or something at least to get it out of this level of hard-coded. (Maybe even labkey...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent is to update these password quarterly, right? So at least extracting them seems smart.