Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .ome from file name generated #468

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

SeanLeRoy
Copy link
Contributor

I noticed .ome is present in the auto-generated file name for .ome.tiff and .ome.zarr files which is kinda incorrect so this adds an additional regex to remove it when/if present

@SeanLeRoy SeanLeRoy requested a review from kmitcham March 11, 2025 00:09
@SeanLeRoy SeanLeRoy self-assigned this Mar 11, 2025
@SeanLeRoy SeanLeRoy linked an issue Mar 11, 2025 that may be closed by this pull request
Copy link

@kmitcham kmitcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if there was a way to put unit tests on that, but I don't have an easy way to do it offhand

@SeanLeRoy SeanLeRoy merged commit caafd7d into main Mar 11, 2025
7 checks passed
@SeanLeRoy SeanLeRoy deleted the bugfix/drop-ome-from-file-name branch March 11, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect file name parsed
4 participants