Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add save-as option to query panel #474

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aswallace
Copy link
Contributor

@aswallace aswallace commented Mar 12, 2025

Context

Allow users to save the full result of a query without individually selecting files
closes #462

Changes

Adds a button to the query panel that opens the same "Download metadata manifest" modal as from the file context menu.
Still waiting on some UX feedback

Questions

Are we concerned about people trying to download the csvs for AICS without any filters applied, since that would be all of FMS (~6 million rows)? Is that something we want to prevent on the UI side or should we allow it with the assumption that people just wouldn't do that?

Testing

Manually tested:

  • Downloading csv for AICS with filters applied
  • Downloading csv, json, and parquet for non-AICS data sources with filters applied

Currently testing:

  • Downloading without filters applied

Screenshots

Screenshot 2025-03-12 at 9 39 19 AM Screenshot 2025-03-12 at 1 20 23 PM

@aswallace aswallace linked an issue Mar 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save/download full result of query
1 participant