Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optional params on components #475

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aswallace
Copy link
Contributor

Context

Minor UX housekeeping: These component properties should be made optional to conform to UX recommendations:

  1. Tooltips are only useful if they add info--should not be present if they would exactly match the button text
  2. Most of our modals should not be movable/should not show the drag cursor

closes #348 and #349

Changes

  • Made title (the tooltip) an optional property for Base, Primary and Secondary buttons. Still required on Tertiary since those are icon-only
  • Made modals non-draggable by default by adding an optional isDraggable property

Testing

  • Updated unit tests since the button dataset-id was previously constructed from title

To do

  • Check with UX on which (if any) modals should still be draggable
  • I made some of the tooltips more descriptive instead of removing them, but am open to suggestions

@aswallace aswallace linked an issue Mar 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to make modal not movable Redundant tooltips on button component
1 participant