diff --git a/packages/core/components/Buttons/BaseButton.tsx b/packages/core/components/Buttons/BaseButton.tsx
index 5dd608af..14227678 100644
--- a/packages/core/components/Buttons/BaseButton.tsx
+++ b/packages/core/components/Buttons/BaseButton.tsx
@@ -17,7 +17,9 @@ interface Props {
menuItems?: IContextualMenuItem[];
onClick?: () => void;
text?: string;
- title: string;
+ // title is only required if tooltip would be different from button text
+ // or if button does not have text (e.g., icon only)
+ title?: string;
}
/**
@@ -60,7 +62,7 @@ export default function BaseButton(props: Props) {
[styles.disabled]: props.disabled,
[styles.selected]: props.isSelected,
})}
- data-testid={`base-button-${props.title}`}
+ data-testid={`base-button-${props.id}`}
ariaLabel={props.title}
disabled={props.disabled}
id={props.id}
diff --git a/packages/core/components/Buttons/PrimaryButton.tsx b/packages/core/components/Buttons/PrimaryButton.tsx
index 20f82c30..ea4a26df 100644
--- a/packages/core/components/Buttons/PrimaryButton.tsx
+++ b/packages/core/components/Buttons/PrimaryButton.tsx
@@ -15,7 +15,7 @@ interface Props {
menuItems?: IContextualMenuItem[];
onClick?: () => void;
text?: string;
- title: string;
+ title?: string;
}
/**
diff --git a/packages/core/components/Buttons/SecondaryButton.tsx b/packages/core/components/Buttons/SecondaryButton.tsx
index dc5454c2..ee41422f 100644
--- a/packages/core/components/Buttons/SecondaryButton.tsx
+++ b/packages/core/components/Buttons/SecondaryButton.tsx
@@ -15,7 +15,7 @@ interface Props {
menuItems?: IContextualMenuItem[];
onClick?: () => void;
text?: string;
- title: string;
+ title?: string;
}
/**
diff --git a/packages/core/components/Buttons/test/BaseButton.test.tsx b/packages/core/components/Buttons/test/BaseButton.test.tsx
index b7aa99eb..a6d125a3 100644
--- a/packages/core/components/Buttons/test/BaseButton.test.tsx
+++ b/packages/core/components/Buttons/test/BaseButton.test.tsx
@@ -8,20 +8,21 @@ describe("