Skip to content

calculate site spacing for npx 2.0 compatibility #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eggriel
Copy link

@eggriel eggriel commented Jun 6, 2025

add function load_channel_position to change site spacing accordingly. Site spacing is different for npx 1.0 and npx 2.0.

@jsiegle
Copy link
Collaborator

jsiegle commented Jun 10, 2025

Hi @eggriel -- currently site spacing is specified as part of the input JSON (schema definition here). It looks like you're trying to load this from the first two rows of the channel_positions.npy file instead. One issue I foresee with this approach is that if an alternate electrode configuration is selected, the distance between the first two rows might not be equal to the actual electrode spacing. So it's probably safer to specify the spacing in the JSON file, based on the known electrode type. Is there a reason you'd like to avoid this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants