Avoid calling next more than once when navigating from / to /errata #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
javihernandez
force-pushed
the
bs-430
branch
from
eb30d54 to
b5d29f9
Compare
pastalian
reviewed
Feb 14, 2025
src/router/routes.js
Outdated
| .dispatch('platforms/loadPlatformList') | ||
| .then(next()) | ||
| .catch(next()) | ||
| store.dispatch('platforms/loadPlatformList').then(next()) |
There was a problem hiding this comment.
I think I found the cause. dispatch() returns a Promise, so then(next()) does not wait for loadPlatformList to complete.
Suggested change
| store.dispatch('platforms/loadPlatformList').then(next()) | |
| store.dispatch('platforms/loadPlatformList').then(() => next()) |
There was a problem hiding this comment.
ohh, I see, can you try now?
There was a problem hiding this comment.
Yes, this fixes my issue. Thanks a lot!
(There are other then(next()) in route.js, which might not be intentional either.)
javihernandez
force-pushed
the
bs-430
branch
from
b5d29f9 to
fa0e4eb
Compare
javihernandez
force-pushed
the
bs-430
branch
from
fa0e4eb to
889b8bc
Compare
anfimovdm
approved these changes
Feb 17, 2025
maccelf
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AlmaLinux/build-system#430