Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release plan for modular builds #791

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

Korulag
Copy link
Contributor

@Korulag Korulag commented Apr 11, 2024

Copy link

pylint output
************* Module alws.release_planner
alws/release_planner.py:1453:0: C0301: Line too long (111/80) (line-too-long)
alws/release_planner.py:1754:0: C0301: Line too long (115/80) (line-too-long)
alws/release_planner.py:1:0: C0302: Too many lines in module (1899/1000) (too-many-lines)
alws/release_planner.py:556:13: W0511: TODO: Add packages presence check in community repos (fixme)
alws/release_planner.py:831:9: W0511: TODO: Add support for checking existent packages in repos (fixme)
alws/release_planner.py:1589:21: W0511: TODO: need to send only one repo instead of list (fixme)
alws/release_planner.py:1781:17: W0511: TODO: we already have all repos in self.base_platform.repos, (fixme)
alws/release_planner.py:1:0: C0114: Missing module docstring (missing-module-docstring)
alws/release_planner.py:69:0: C0115: Missing class docstring (missing-class-docstring)
alws/release_planner.py:88:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:106:15: W0718: Catching too general exception Exception (broad-exception-caught)
alws/release_planner.py:119:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:156:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:163:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:167:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:177:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:185:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:192:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:192:22: W0613: Unused argument 'build' (unused-argument)
alws/release_planner.py:196:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:199:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:209:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:246:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:246:4: R0914: Too many local variables (27/15) (too-many-locals)
alws/release_planner.py:380:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:393:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:437:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:523:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:567:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:596:15: W0718: Catching too general exception Exception (broad-exception-caught)
alws/release_planner.py:609:23: W0718: Catching too general exception Exception (broad-exception-caught)
alws/release_planner.py:633:0: C0115: Missing class docstring (missing-class-docstring)
alws/release_planner.py:659:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:670:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:703:4: R0914: Too many local variables (25/15) (too-many-locals)
alws/release_planner.py:722:12: W0612: Unused variable 'src_rpm_names' (unused-variable)
alws/release_planner.py:802:4: R0914: Too many local variables (27/15) (too-many-locals)
alws/release_planner.py:910:0: C0115: Missing class docstring (missing-class-docstring)
alws/release_planner.py:977:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:977:4: R0914: Too many local variables (30/15) (too-many-locals)
alws/release_planner.py:977:4: R0912: Too many branches (14/12) (too-many-branches)
alws/release_planner.py:1073:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1090:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1090:4: R0913: Too many arguments (6/5) (too-many-arguments)
alws/release_planner.py:1113:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1164:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1164:4: R0913: Too many arguments (7/5) (too-many-arguments)
alws/release_planner.py:1205:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1205:4: R0913: Too many arguments (8/5) (too-many-arguments)
alws/release_planner.py:1205:4: R0914: Too many local variables (20/15) (too-many-locals)
alws/release_planner.py:1289:4: W0237: Parameter 'base_platform' has been renamed to 'build_ids' in overriding 'AlmaLinuxReleasePlanner.get_release_plan' method (arguments-renamed)
alws/release_planner.py:1289:4: W0237: Parameter 'build_ids' has been renamed to 'base_platform' in overriding 'AlmaLinuxReleasePlanner.get_release_plan' method (arguments-renamed)
alws/release_planner.py:1289:4: R0914: Too many local variables (67/15) (too-many-locals)
alws/release_planner.py:1289:4: R0912: Too many branches (32/12) (too-many-branches)
alws/release_planner.py:1289:4: R0915: Too many statements (122/50) (too-many-statements)
alws/release_planner.py:1609:4: R0914: Too many local variables (46/15) (too-many-locals)
alws/release_planner.py:1631:16: W0707: Consider explicitly re-raising using 'raise SignError(msg) from e' (raise-missing-from)
alws/release_planner.py:1609:4: R0912: Too many branches (27/12) (too-many-branches)
alws/release_planner.py:1609:4: R0915: Too many statements (92/50) (too-many-statements)
alws/release_planner.py:1810:4: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:1892:0: C0116: Missing function or method docstring (missing-function-docstring)
alws/release_planner.py:19:0: W0611: Unused GitHubIssueStatus imported from alws.constants (unused-import)

-----------------------------------
Your code has been rated at 9.23/10

@Korulag Korulag force-pushed the fix-modules-release-plan branch from 6a035a9 to 2c529d0 Compare April 11, 2024 09:39
Copy link

Total coverage

Coverage report for changed files •
FileStmtsMissCoverMissing
release_planner.py83443048%79, 98, 101, 106–111, 131, 160, 174, 182, 189, 197, 200–202, 205–206, 216, 224, 232, 276–277, 287–288, 296–308, 312–322, 324–328, 334–337, 346, 349–353, 361, 377–378, 444, 446, 463–464, 468, 487–489, 494–495, 499–504, 510–517, 519–520, 529–530, 532–534, 536–537, 541–543, 546–549, 555, 557–564, 577, 580, 588, 594–598, 607–610, 718, 730, 732–733, 738, 745–746, 750–757, 762–764, 768–771, 776–777, 779–781, 783–784, 787, 789, 799, 810, 841, 861, 923, 927–932, 1024, 1033–1039, 1055–1069, 1087, 1106, 1128, 1136, 1140, 1143, 1173–1174, 1182–1188, 1192–1193, 1198–1203, 1215–1216, 1224–1226, 1230, 1233–1235, 1239, 1242–1243, 1252, 1256, 1260–1264, 1268–1270, 1275–1277, 1281–1286, 1315–1317, 1320, 1322–1323, 1330–1332, 1334–1335, 1337, 1342, 1349–1353, 1357–1359, 1361, 1364, 1370–1372, 1378–1379, 1383–1392, 1401–1403, 1406, 1411–1414, 1420–1422, 1426–1427, 1435–1437, 1439–1440, 1448–1452, 1455, 1461–1462, 1465, 1474–1475, 1481–1494, 1505–1506, 1515–1519, 1524–1525, 1531–1532, 1536–1543, 1548, 1550–1551, 1556, 1562–1564, 1568–1571, 1573–1580, 1585–1588, 1593–1594, 1596, 1600, 1620, 1629–1631, 1633–1634, 1641, 1653, 1665, 1680–1683, 1698–1703, 1710–1712, 1715–1717, 1720–1726, 1729–1730, 1732–1734, 1739–1740, 1744, 1746–1747, 1759, 1770, 1772, 1775, 1791, 1815, 1869–1871, 1877–1879
TOTAL10008445355% 

Tests Skipped Failures Errors Time
82 13 💤 0 ❌ 0 🔥 33.301s ⏱️

@Korulag Korulag merged commit dab7949 into master Apr 17, 2024
4 checks passed
@Korulag Korulag deleted the fix-modules-release-plan branch April 17, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive amount of modules in the release plan
4 participants