Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild of membership page #737

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Conversation

bennyvasquez
Copy link
Member

This page was in dire need of updates - so I did them all.

  • update the membership options to match the ones that the board approved last year, add member images
  • fix page formatting and display to match what we've been using for the website more widely
  • Add more context to the board members section

@jonathanspw
Copy link
Member

The "apply" buttons all seem to 404. Is that expected?

@bennyvasquez
Copy link
Member Author

@jonathanspw nope, that's definitely not intentional. (looks like that /viewform really needs to be part of the URL :D) fixed in latest commit.

Copy link
Member

@javihernandez javihernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bennyvasquez, the new content is definitely great, thanks for this update!
In my opinion, the column-based approach (which I like) is making the content to look a bit messy. Look

image

I'm not sure how to make it look better, but just for inspiration, you can probably try adding tables, playing around with padding to make it less "condensed", ensure that both columns take the same space or try adding some spacing between sections.

@bennyvasquez
Copy link
Member Author

Copy link
Contributor

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more or less good, but I think it's a little weird that the Platinum and Silver badges don't use the colors they reference while the ruby and gold ones do.

@bennyvasquez
Copy link
Member Author

Fixed @Conan-Kudo! Thank you for that!

Copy link
Contributor

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platinum Sponsor badge has the wrong text.

Copy link
Contributor

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colors don't seem right for Silver and Platinum badges either.

@bennyvasquez bennyvasquez merged commit d4f5de5 into master Jan 23, 2025
2 checks passed
@bennyvasquez bennyvasquez deleted the update_sponsor_member_options branch January 23, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants