-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild of membership page #737
Conversation
The "apply" buttons all seem to 404. Is that expected? |
@jonathanspw nope, that's definitely not intentional. (looks like that /viewform really needs to be part of the URL :D) fixed in latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @bennyvasquez, the new content is definitely great, thanks for this update!
In my opinion, the column-based approach (which I like) is making the content to look a bit messy. Look
I'm not sure how to make it look better, but just for inspiration, you can probably try adding tables, playing around with padding to make it less "condensed", ensure that both columns take the same space or try adding some spacing between sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more or less good, but I think it's a little weird that the Platinum and Silver badges don't use the colors they reference while the ruby and gold ones do.
Fixed @Conan-Kudo! Thank you for that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platinum Sponsor badge has the wrong text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colors don't seem right for Silver and Platinum badges either.
This page was in dire need of updates - so I did them all.