Fix cache in tests-cacher #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwaizer
force-pushed
the
fix-cache
branch
4 times, most recently
from
88e5eba to
0851071
Compare
maccelf
reviewed
Jan 29, 2025
alma_tests_cacher/cacher.py
Outdated
| @@ -118,6 +119,21 @@ async def get_test_repositories(self) -> List[TestRepository]: | |||
| test_repos.append(TestRepository(**test_repo)) | |||
| return test_repos | |||
|
|
|||
| def get_compiled_test_rules( | |||
| self, | |||
anfimovdm
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Could you please check how it works with the following case?
- Process some repo one time to let the service to cache a git repository
- Add to the repo a new test dir and define a regex in
test_rules.json - Check how it works
- Repeat second and third steps again
Note: Please, don't turn off or restart the service when you will try to reproduce the error with cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: AlmaLinux/build-system#411
Git pull works properly in local testing, so this problem can be addressed with a hotfix where we re-clone repository if missing folders are found