[BUG]: Errata list does not display correctly due to race condition #430
Comments
`this.platforms` is a computed value and may be empty when `platformName()` is executed, which can result in accessing a non-existent `label` property. This fix unsure that matched platform exists before accessing it, preventing UI breakage. Fixes: AlmaLinux/build-system#430
|
Hey @pastalian, thanks for the report!
|
|
Tested with:
/api/v1/platforms/[
{
"id": 1,
"name": "AlmaLinux-8",
"distr_type": "rhel",
"distr_version": "8",
"pgp_key": null,
"arch_list": [
"i686",
"x86_64",
"aarch64",
"ppc64le",
"s390x"
],
"modularity": {
"versions": [
{
"name": "8.4",
"dist_prefix": "el8.4.0",
"version_prefix": "80400"
},
{
"name": "8.5",
"dist_prefix": "el8.5.0",
"version_prefix": "80500"
},
{
"name": "8.6",
"dist_prefix": "el8.6.0",
"version_prefix": "80600"
},
{
"name": "8.7",
"dist_prefix": "el8.7.0",
"version_prefix": "80700"
},
{
"name": "8.8",
"dist_prefix": "el8.8.0",
"version_prefix": "80800"
},
{
"name": "8.9",
"dist_prefix": "el8.9.0",
"version_prefix": "80900"
},
{
"name": "8.10",
"dist_prefix": "el8.10.0",
"version_prefix": "81000"
}
],
"packages_git": "https://git.almalinux.org/rpms/",
"git_tag_prefix": {
"modified": "a8",
"non_modified": "c8"
},
"modified_packages_url": "https://git.almalinux.org/almalinux/modified_packages/raw/branch/main/a8.yml"
}
},
{
"id": 2,
"name": "AlmaLinux-9",
"distr_type": "rhel",
"distr_version": "9",
"pgp_key": null,
"arch_list": [
"i686",
"x86_64",
"aarch64",
"ppc64le",
"s390x"
],
"modularity": {
"versions": [
{
"name": "9",
"dist_prefix": "el9.0.0",
"version_prefix": "90000"
},
{
"name": "9.1",
"dist_prefix": "el9.1.0",
"version_prefix": "90100"
},
{
"name": "9.2",
"dist_prefix": "el9.2.0",
"version_prefix": "90200"
},
{
"name": "9.3",
"dist_prefix": "el9.3.0",
"version_prefix": "90300"
},
{
"name": "9.4",
"dist_prefix": "el9.4.0",
"version_prefix": "90400"
},
{
"name": "9.5",
"dist_prefix": "el9.5.0",
"version_prefix": "90500"
}
],
"packages_git": "https://git.almalinux.org/rpms/",
"git_tag_prefix": {
"modified": "a9",
"non_modified": "c9"
},
"modified_packages_url": "https://git.almalinux.org/almalinux/modified_packages/raw/branch/main/a9.yml"
}
},
{
"id": 3,
"name": "AlmaLinux-10",
"distr_type": "rhel",
"distr_version": "10",
"pgp_key": null,
"arch_list": [
"x86_64",
"x86_64_v2",
"aarch64",
"ppc64le",
"s390x",
"riscv64"
],
"modularity": null
},
{
"id": 4,
"name": "AlmaLinux-Kitten-10",
"distr_type": "rhel",
"distr_version": "10",
"pgp_key": null,
"arch_list": [
"x86_64",
"x86_64_v2",
"aarch64",
"ppc64le",
"s390x",
"riscv64"
],
"modularity": null
}
]/api/v1/errata/all/[
{
"id": "ALSA-2025:A005",
"updated_date": "2025-02-14T00:00:00",
"platform_id": 1
},
{
"id": "ALSA-2025:A004",
"updated_date": "2025-02-14T00:00:00",
"platform_id": 2
},
{
"id": "ALSA-2025:A003",
"updated_date": "2025-02-14T00:00:00",
"platform_id": 2
},
{
"id": "ALSA-2025:A002",
"updated_date": "2025-02-12T00:00:00",
"platform_id": 2
},
{
"id": "ALSA-2025:A001",
"updated_date": "2025-02-12T00:00:00",
"platform_id": 2
}
]
Checking the console log confirms that diff --git a/src/pages/ErrataFeed.vue b/src/pages/ErrataFeed.vue
index 84bd681..29c09bd 100644
--- a/src/pages/ErrataFeed.vue
+++ b/src/pages/ErrataFeed.vue
@@ -532,6 +532,7 @@
return advisory.title ? advisory.title : advisory.original_title
},
platformName(id) {
+ console.log(this.platforms)
return this.platforms.find((platform) => platform.value == id).label
},
},
|
|
Hmm, maybe this is specific to Firefox.
|
|
Hm, interesting, I'm on Firefox 134, and working fine here. What's yours? {
path: 'errata',
component: () => import('pages/ErrataFeed.vue'),
beforeEnter(to, from, next) {
store
.dispatch('platforms/loadPlatformList')
.then(next())
.catch(next())
},
},The platform list is dispatched (and stored) before loading the page, that's why I think that it's a different problem, or something weird happened in a recent Vue.js (or related) update. |
|
I have Firefox 135 🤔 |
|
Interesting, I can reproduce it now with both versions of Firefox (webkit-based ones work fine). However, I can only reproduce the problem sometimes when you navigate from |
|
It didn't work for me :( |
Can you double check that it is still happening when navigating from / (build feed) to errata? If you are navigating from other path, then, we should try fixing that one too. Also, does it change when you are logged in vs logged out? |
|
Yeah, I'm still having the issue with
I'm not seeing any difference between logged in/out. |
|
OK, so enabling "Disable Cache" from "F12 -> Network tab" seems to fix it. |
Can you please enable it back? Then, check if the problem goes away with and without my fix |
|
Is there an existing issue for this?
Current Behavior
Only the first errata entry is displayed, and "Loading..." never finishes.
Errata info is not displayed.
Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
this.platformsis a computed value and may be empty when platformName() is executed, which can result in accessing a non-existentlabelproperty.platforms: https://github.com/AlmaLinux/albs-frontend/blob/d394c514f297ffa59682f97418fc44b08f2beb51/src/pages/ErrataFeed.vue#L309
platformName: https://github.com/AlmaLinux/albs-frontend/blob/d394c514f297ffa59682f97418fc44b08f2beb51/src/pages/ErrataFeed.vue#L534
Search terms
errata
The text was updated successfully, but these errors were encountered: