Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review routes and ensure that there are no more navigation warnings around calling next more than once #435

Open
javihernandez opened this issue Feb 17, 2025 · 0 comments
Labels
good first issue Good for newcomers ui UI (frontend) related issues

Comments

@javihernandez
Copy link
Member

As unveiled in the following issue and resolved in this PR, there might be some navigation in other places due to use of calling next() as part of promise handling in the routing process.

We should review albs-frontend's routes.js and ensure that:

  • We stop calling next, and pass it as a callback in the promise resolution process
  • Several store/state dispatchers in beforeEnter should be wrapped into a Promise.all

After the update, we need to check that the navigation works as expected and that there are no more navigation warnings around.

@javihernandez javihernandez added good first issue Good for newcomers ui UI (frontend) related issues labels Feb 17, 2025
@javihernandez javihernandez moved this to Ready for dev in AlmaLinux Build System Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ui UI (frontend) related issues
Projects
Status: Ready for dev
Development

No branches or pull requests

1 participant