Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve error handling in D2Wrapper #16

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat: Improve error handling in D2Wrapper #16

merged 2 commits into from
Aug 6, 2024

Conversation

AlrikOlson
Copy link
Owner

@AlrikOlson AlrikOlson commented Aug 6, 2024 •
edited
Loading

This PR improves error handling in D2Wrapper and updates the web demo accordingly:

  1. Added RenderResult class to return either SVG or error info.
  2. Implemented detailed error parsing (line numbers, columns, messages).
  3. Updated web demo to display errors with highlighting.
  4. Added error handling examples to README.
  5. Refactored web demo to use new error reporting features.

These changes aim to provide clearer error information, making D2 script debugging easier.

@AlrikOlson AlrikOlson changed the title error handling feat: Improve error handling and reporting in D2Wrapper Aug 6, 2024
@AlrikOlson AlrikOlson changed the title feat: Improve error handling and reporting in D2Wrapper feat: Improve error handling in D2Wrapper Aug 6, 2024
@AlrikOlson AlrikOlson enabled auto-merge (squash) August 6, 2024 03:39
@AlrikOlson AlrikOlson merged commit 701a9e4 into main Aug 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlrikOlson