increase coverage

Author: AmrSaber

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 .vscode
-dist
+dist
+coverage

src/index.ts

@@ -141,28 +141,24 @@ export async function tryLock(
   const release: ReleaseFunc = async function () {
     if (released) return;
 
-    if (!isRedisClient(redis)) {
-      await redis.eval(releaseScript, {
-        keys: [lockKey, REDIS_RELEASES_CHANNEL],
-        arguments: [lockValue],
-      });
+    const evalParams = {
+      keys: [lockKey, REDIS_RELEASES_CHANNEL],
+      arguments: [lockValue],
+    };
 
+    if (!isRedisClient(redis)) {
+      await redis.eval(releaseScript, evalParams);
       released = true;
       return;
     }
 
     // If it's redis client, cache the script and use its SHA
     if (scriptHash == null) scriptHash = await redis.scriptLoad(releaseScript);
 
-    await redis
-      .evalSha(scriptHash, {
-        keys: [lockKey, REDIS_RELEASES_CHANNEL],
-        arguments: [lockValue],
-      })
-      .catch((err: Error) => {
-        if (err.message.includes('NOSCRIPT')) scriptHash = null; // Signal script flushed
-        else throw err;
-      });
+    await redis.evalSha(scriptHash, evalParams).catch((err: Error) => {
+      if (err.message.includes('NOSCRIPT')) scriptHash = null; // Signal script flushed
+      else throw err;
+    });
 
     if (scriptHash == null) await release(); // If script flushed, try again
     released = true;

unit.test.ts

@@ -39,6 +39,22 @@ describe('Lock tests', () => {
       expect(release.fencingToken).toEqual(-1);
     });
 
+    test('release works without script cache', async () => {
+      const scriptLoad = redis.scriptLoad;
+      // @ts-ignore
+      redis.scriptLoad = null;
+
+      let [hasLock, release] = await tryLock(redis, lockName);
+      expect(hasLock).toEqual(true);
+
+      await release();
+
+      [hasLock, release] = await tryLock(redis, lockName);
+      expect(hasLock).toEqual(true);
+
+      redis.scriptLoad = scriptLoad;
+    });
+
     test('it issues monotonic fencing tokens', async () => {
       let lastToken: number | null = null;