Cut 1.5.0

Author: bbatsov

.github/ISSUE_TEMPLATE/bug_report.md

@@ -38,7 +38,7 @@ output by `rubocop -V`, include them as well. Here's an example:
 
 ```
 $ [bundle exec] rubocop -V
-1.4.2 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.5.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
   - rubocop-performance 1.9.1
   - rubocop-rspec 2.0.0
 ```

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master (unreleased)
 
+## 1.5.0 (2020-12-01)
+
 ### New features
 
 * [#9112](https://github.com/rubocop-hq/rubocop/pull/9112): Add new cop `Lint/UnexpectedBlockArity`. ([@dvandersluis][])

CONTRIBUTING.md

@@ -17,7 +17,7 @@ do so.
 
 ```
 $ rubocop -V
-1.4.2 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.5.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
   - rubocop-performance 1.9.1
   - rubocop-rspec 2.0.0
 ```

README.md

@@ -51,7 +51,7 @@ To prevent an unwanted RuboCop update you might want to use a conservative versi
 in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 1.4', require: false
+gem 'rubocop', '~> 1.5', require: false
 ```
 
 See [versioning](https://docs.rubocop.org/rubocop/1.0/versioning.html) for further details.

config/default.yml

@@ -2012,7 +2012,7 @@ Lint/UnexpectedBlockArity:
   Description: 'Looks for blocks that have fewer arguments that the calling method expects.'
   Enabled: pending
   Safe: false
-  VersionAdded: <<next>>
+  VersionAdded: '1.5'
   Methods:
     chunk_while: 2
     each_with_index: 2
@@ -2034,7 +2034,7 @@ Lint/UnmodifiedReduceAccumulator:
   Description: Checks for `reduce` or `inject` blocks that do not update the accumulator each iteration.
   Enabled: pending
   VersionAdded: '1.1'
-  VersionChanged: <<next>>
+  VersionChanged: '1.5'
 
 Lint/UnreachableCode:
   Description: 'Unreachable code.'
@@ -2138,7 +2138,7 @@ Metrics/AbcSize:
     - https://en.wikipedia.org/wiki/ABC_Software_Metric
   Enabled: true
   VersionAdded: '0.27'
-  VersionChanged: '<<next>>'
+  VersionChanged: '1.5'
   # The ABC size is a calculated magnitude, so this number can be an Integer or
   # a Float.
   IgnoredMethods: []
@@ -2149,7 +2149,7 @@ Metrics/BlockLength:
   Description: 'Avoid long blocks with many lines.'
   Enabled: true
   VersionAdded: '0.44'
-  VersionChanged: <<next>>
+  VersionChanged: '1.5'
   CountComments: false  # count full line comments?
   Max: 25
   CountAsOne: []
@@ -2195,7 +2195,7 @@ Metrics/MethodLength:
   StyleGuide: '#short-methods'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: <<next>>
+  VersionChanged: '1.5'
   CountComments: false  # count full line comments?
   Max: 10
   CountAsOne: []
@@ -2216,7 +2216,7 @@ Metrics/ParameterLists:
   StyleGuide: '#too-many-params'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: '<<next>>'
+  VersionChanged: '1.5'
   Max: 5
   CountKeywordArgs: true
   MaxOptionalParameters: 3
@@ -4301,7 +4301,7 @@ Style/SoleNestedConditional:
                   which can be merged into outer conditional node.
   Enabled: true
   VersionAdded: '0.89'
-  VersionChanged: '<<next>>'
+  VersionChanged: '1.5'
   AllowModifier: false
 
 Style/SpecialGlobalVars:
@@ -4434,7 +4434,7 @@ Style/SymbolProc:
   Enabled: true
   Safe: false
   VersionAdded: '0.26'
-  VersionChanged: <<next>>
+  VersionChanged: '1.5'
   # A list of method names to be ignored by the check.
   # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
   IgnoredMethods:

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop
 title: RuboCop
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: 'master'
+version: '1.5'
 nav:
 - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops.adoc

@@ -278,6 +278,7 @@ In the following section you find all available cops:
 * xref:cops_lint.adoc#linttoplevelreturnwithargument[Lint/TopLevelReturnWithArgument]
 * xref:cops_lint.adoc#linttrailingcommainattributedeclaration[Lint/TrailingCommaInAttributeDeclaration]
 * xref:cops_lint.adoc#lintunderscoreprefixedvariablename[Lint/UnderscorePrefixedVariableName]
+* xref:cops_lint.adoc#lintunexpectedblockarity[Lint/UnexpectedBlockArity]
 * xref:cops_lint.adoc#lintunifiedinteger[Lint/UnifiedInteger]
 * xref:cops_lint.adoc#lintunmodifiedreduceaccumulator[Lint/UnmodifiedReduceAccumulator]
 * xref:cops_lint.adoc#lintunreachablecode[Lint/UnreachableCode]

docs/modules/ROOT/pages/cops_lint.adoc

@@ -4605,6 +4605,62 @@ end
 | Boolean
 |===
 
+== Lint/UnexpectedBlockArity
+
+|===
+| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+
+| Pending
+| No
+| No
+| 1.5
+| -
+|===
+
+This cop checks for a block that is known to need more positional
+block arguments than are given (by default this is configured for
+`Enumerable` methods needing 2 arguments). Optional arguments are allowed,
+although they don't generally make sense as the default value will
+be used. Blocks that have no receiver, or take splatted arguments
+(ie. `*args`) are always accepted.
+
+Keyword arguments (including `**kwargs`) do not get counted towards
+this, as they are not used by the methods in question.
+
+NOTE: This cop matches for method names only and hence cannot tell apart
+methods with same name in different classes.
+
+Method names and their expected arity can be configured like this:
+
+Methods:
+  inject: 2
+  reduce: 2
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+values.reduce {}
+values.min { |a| a }
+values.sort { |a; b| a + b }
+
+# good
+values.reduce { |memo, obj| memo << obj }
+values.min { |a, b| a <=> b }
+values.sort { |*x| x[0] <=> x[1] }
+----
+
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| Methods
+| `{"chunk_while"=>2, "each_with_index"=>2, "each_with_object"=>2, "inject"=>2, "max"=>2, "min"=>2, "minmax"=>2, "reduce"=>2, "slice_when"=>2, "sort"=>2}`
+| 
+|===
+
 == Lint/UnifiedInteger
 
 |===
@@ -4645,7 +4701,7 @@ This cop checks for using Fixnum or Bignum constant.
 | Yes
 | No
 | 1.1
-| -
+| 1.5
 |===
 
 Looks for `reduce` or `inject` blocks where the value returned (implicitly or
@@ -4657,8 +4713,7 @@ block will just return a transformation of the last element value, and
 could be rewritten as such without a loop.
 
 Also catches instances where an index of the accumulator is returned, as
-this may change the type of object being retained. As well, detects when
-fewer than 2 block arguments are specified.
+this may change the type of object being retained.
 
 NOTE: For the purpose of reducing false positives, this cop only flags
 returns in `reduce` blocks where the element is the only variable in