Cut 1.6

Author: bbatsov

.github/ISSUE_TEMPLATE/bug_report.md

@@ -38,7 +38,7 @@ output by `rubocop -V`, include them as well. Here's an example:
 
 ```
 $ [bundle exec] rubocop -V
-1.5.2 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.6.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
   - rubocop-performance 1.9.1
   - rubocop-rspec 2.0.0
 ```

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master (unreleased)
 
+## 1.6.0 (2020-12-09)
+
 ### New features
 
 * [#9125](https://github.com/rubocop-hq/rubocop/issues/9125): Allow ConfigObsoletion to be extended by other RuboCop libraries. ([@dvandersluis][])

CONTRIBUTING.md

@@ -17,7 +17,7 @@ do so.
 
 ```
 $ rubocop -V
-1.5.2 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.6.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
   - rubocop-performance 1.9.1
   - rubocop-rspec 2.0.0
 ```

README.md

@@ -51,7 +51,7 @@ To prevent an unwanted RuboCop update you might want to use a conservative versi
 in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 1.5', require: false
+gem 'rubocop', '~> 1.6', require: false
 ```
 
 See [versioning](https://docs.rubocop.org/rubocop/1.0/versioning.html) for further details.

config/default.yml

@@ -3212,7 +3212,7 @@ Style/FloatDivision:
   Reference: 'https://blog.rubystyle.guide/ruby/2019/06/21/float-division.html'
   Enabled: true
   VersionAdded: '0.72'
-  VersionChanged: <<next>>
+  VersionChanged: '1.6'
   EnforcedStyle: single_coerce
   SupportedStyles:
     - left_coerce
@@ -4026,7 +4026,7 @@ Style/RedundantArgument:
   Enabled: pending
   Safe: false
   VersionAdded: '1.4'
-  VersionChanged: <<next>>
+  VersionChanged: '1.6'
   Methods:
     # Array#join
     join: ''
@@ -4274,7 +4274,7 @@ Style/SingleLineBlockParams:
   Description: 'Enforces the names of some block params.'
   Enabled: false
   VersionAdded: '0.16'
-  VersionChanged: <<next>>
+  VersionChanged: '1.6'
   Methods:
     - reduce:
         - acc
@@ -4347,7 +4347,7 @@ Style/StringConcatenation:
   Enabled: true
   Safe: false
   VersionAdded: '0.89'
-  VersionChanged: <<next>>
+  VersionChanged: '1.6'
 
 Style/StringHashKeys:
   Description: 'Prefer symbols instead of strings as hash keys.'

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop
 title: RuboCop
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: 'master'
+version: '1.6'
 nav:
 - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_naming.adoc

@@ -12,7 +12,13 @@
 | -
 |===
 
-This cop makes sure that accessor methods are named properly.
+This cop makes sure that accessor methods are named properly. Applies
+to both instance and class methods.
+
+NOTE: Offenses are only registered for methods with the expected
+arity. Getters (`get_attribute`) must have no arguments to be
+registered, and setters (`set_attribute(value)`) must have exactly
+one.
 
 === Examples
 
@@ -33,6 +39,14 @@ end
 # good
 def attribute
 end
+
+# accepted, incorrect arity for getter
+def get_value(attr)
+end
+
+# accepted, incorrect arity for setter
+def set_value
+end
 ----
 
 === References

docs/modules/ROOT/pages/cops_style.adoc

@@ -3390,9 +3390,9 @@ for numbers in the code (eg 1.2e4). Different styles are supported:
 
 | Enabled
 | Yes
-| No
+| Yes
 | 0.72
-| -
+| 1.6
 |===
 
 This cop checks for division with integers coerced to floats.
@@ -3463,7 +3463,7 @@ a.fdiv(b)
 === References
 
 * https://rubystyle.guide#float-division
-* https://github.com/rubocop-hq/ruby-style-guide/issues/628
+* https://blog.rubystyle.guide/ruby/2019/06/21/float-division.html
 
 == Style/For
 
@@ -7664,7 +7664,8 @@ This cop checks for usage of the %Q() syntax when %q() would do.
 |===
 
 This cop looks for uses of Perl-style regexp match
-backreferences like $1, $2, etc.
+backreferences and their English versions like
+$1, $2, $&, &+, $MATCH, $PREMATCH, etc.
 
 === Examples
 
@@ -7895,9 +7896,9 @@ rand(1...7)
 
 | Pending
 | No
-| No
+| Yes (Unsafe)
 | 1.4
-| -
+| 1.6
 |===
 
 This cop checks for a redundant argument passed to certain methods.
@@ -9581,9 +9582,9 @@ keys = %i[key1 key2]
 
 | Disabled
 | Yes
-| No
+| Yes
 | 0.16
-| 0.47
+| 1.6
 |===
 
 This cop checks whether the block parameters of a single-line
@@ -9817,10 +9818,6 @@ puts $CHILD_STATUS
 puts $LAST_MATCH_INFO
 puts $IGNORECASE
 puts $ARGV # or ARGV
-puts $MATCH
-puts $PREMATCH
-puts $POSTMATCH
-puts $LAST_PAREN_MATCH
 ----
 
 ==== EnforcedStyle: use_perl_names
@@ -9846,10 +9843,6 @@ puts $?
 puts $~
 puts $=
 puts $*
-puts $&
-puts $`
-puts $'
-puts $+
 ----
 
 === Configurable attributes
@@ -10018,7 +10011,7 @@ warn('hello')
 | No
 | Yes (Unsafe)
 | 0.89
-| -
+| 1.6
 |===
 
 This cop checks for places where string concatenation
@@ -10029,6 +10022,10 @@ more complex cases where the resulting code would be harder to read.
 In those cases, it might be useful to extract statements to local
 variables or methods which you can then interpolate in a string.
 
+NOTE: When concatenation between two strings is broken over multiple
+lines, this cop does not register an offense; instead,
+`Style/LineEndConcatenation` will pick up the offense if enabled.
+
 === Examples
 
 [source,ruby]
@@ -10039,6 +10036,10 @@ email_with_name = user.name + ' <' + user.email + '>'
 # good
 email_with_name = "#{user.name} <#{user.email}>"
 email_with_name = format('%s <%s>', user.name, user.email)
+
+# accepted, line-end concatenation
+name = 'First' +
+  'Last'
 ----
 
 === References

docs/modules/ROOT/pages/installation.adoc

@@ -22,7 +22,7 @@ in your `Gemfile`:
 
 [source,rb]
 ----
-gem 'rubocop', '~> 1.5', require: false
+gem 'rubocop', '~> 1.6', require: false
 ----
 
 NOTE: You can check out our progress on the road to version 1.0 https://github.com/rubocop-hq/rubocop/milestone/4[here].

lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.5.2'
+    STRING = '1.6.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, '\
           'rubocop-ast %<rubocop_ast_version>s, ' \

relnotes/v1.6.0.md

@@ -0,0 +1,26 @@
+### New features
+
+* [#9125](https://github.com/rubocop-hq/rubocop/issues/9125): Allow ConfigObsoletion to be extended by other RuboCop libraries. ([@dvandersluis][])
+* [#9182](https://github.com/rubocop-hq/rubocop/pull/9182): Support auto-correction for `Style/RedundantArgument`. ([@koic][])
+* [#9186](https://github.com/rubocop-hq/rubocop/pull/9186): Support auto-correction for `Style/FloatDivision`. ([@koic][])
+* [#9167](https://github.com/rubocop-hq/rubocop/pull/9167): Support auto-correct for `StyleSingleLineBlockParams`. ([@koic][])
+
+### Bug fixes
+
+* [#9177](https://github.com/rubocop-hq/rubocop/pull/9177): Remove back-ref related code from `Style/SpecialGlobalVars`. ([@r7kamura][])
+* [#9160](https://github.com/rubocop-hq/rubocop/issues/9160): Fix an incorrect auto-correct for `Style/IfUnlessModifier` and `Style/SoleNestedConditional` when auto-correction conflicts for guard condition. ([@koic][])
+* [#9174](https://github.com/rubocop-hq/rubocop/issues/9174): Handle send nodes with unparenthesized arguments in `Style/SoleNestedConditional`. ([@dvandersluis][])
+* [#9184](https://github.com/rubocop-hq/rubocop/issues/9184): `Layout/EmptyLinesAroundAttributeAccessor` fails if the attr_accessor is the last line of the file. ([@tas50][])
+
+### Changes
+
+* [#9171](https://github.com/rubocop-hq/rubocop/pull/9171): Add "did you mean" message when failing due to invalid cops in configuration. ([@dvandersluis][])
+* [#8897](https://github.com/rubocop-hq/rubocop/issues/8897): Change `Style/StringConcatenation` to accept line-end concatenation between two strings so that `Style/LineEndConcatenation` can handle it instead. ([@dvandersluis][])
+* [#9172](https://github.com/rubocop-hq/rubocop/pull/9172): Add `Style/PerlBackrefs` targets and change message more detailed. ([@r7kamura][])
+* [#9187](https://github.com/rubocop-hq/rubocop/pull/9187): Update formatters to output `[Correctable]` for correctable offenses. ([@dvandersluis][])
+* [#9169](https://github.com/rubocop-hq/rubocop/pull/9169): Add obsoletion warnings for `Performance/*` and `Rails/*` which are in separate gems now. ([@dvandersluis][])
+
+[@dvandersluis]: https://github.com/dvandersluis
+[@koic]: https://github.com/koic
+[@r7kamura]: https://github.com/r7kamura
+[@tas50]: https://github.com/tas50