Cut 1.4

Author: bbatsov

.github/ISSUE_TEMPLATE/bug_report.md

@@ -36,5 +36,5 @@ Include the output of `rubocop -V` or `bundle exec rubocop -V` if using Bundler.
 
 ```
 $ [bundle exec] rubocop -V
-1.3.1 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.4.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
 ```

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master (unreleased)
 
+## 1.4.0 (2020-11-23)
+
 ### New features
 
 * [#7737](https://github.com/rubocop-hq/rubocop/issues/7737): Add new `Style/RedundantArgument` cop. ([@tejasbubane][])

CONTRIBUTING.md

@@ -17,7 +17,7 @@ do so.
 
 ```
 $ rubocop -V
-1.3.1 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
+1.4.0 (using Parser 2.7.2.0, rubocop-ast 1.1.1, running on ruby 2.7.2 x86_64-linux)
 ```
 
 * Include any relevant code to the issue summary.

README.md

@@ -51,7 +51,7 @@ To prevent an unwanted RuboCop update you might want to use a conservative versi
 in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 1.3', require: false
+gem 'rubocop', '~> 1.4', require: false
 ```
 
 See [versioning](https://docs.rubocop.org/rubocop/1.0/versioning.html) for further details.

config/default.yml

@@ -463,7 +463,7 @@ Layout/EmptyLineBetweenDefs:
   StyleGuide: '#empty-lines-between-methods'
   Enabled: true
   VersionAdded: '0.49'
-  VersionChanged: <<next>>
+  VersionChanged: '1.4'
   EmptyLineBetweenMethodDefs: true
   EmptyLineBetweenClassDefs: true
   EmptyLineBetweenModuleDefs: true
@@ -895,7 +895,7 @@ Layout/LineLength:
   StyleGuide: '#max-line-length'
   Enabled: true
   VersionAdded: '0.25'
-  VersionChanged: '<<next>>'
+  VersionChanged: '1.4'
   AutoCorrect: true
   Max: 120
   # To make it possible to copy or click on URIs in the code, we allow lines
@@ -1688,7 +1688,7 @@ Lint/MissingSuper:
                   without calls to `super`'.
   Enabled: true
   VersionAdded: '0.89'
-  VersionChanged: '<<next>>'
+  VersionChanged: '1.4'
 
 Lint/MixedRegexpCaptureTypes:
   Description: 'Do not mix named captures and numbered captures in a Regexp literal.'
@@ -3985,7 +3985,7 @@ Style/RedundantArgument:
   Description: 'Check for a redundant argument passed to certain methods.'
   Enabled: pending
   Safe: false
-  VersionAdded: <<next>>
+  VersionAdded: '1.4'
   Methods:
     # Array#join
     join: ''

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop
 title: RuboCop
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: 'master'
+version: '1.4'
 nav:
 - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops.adoc

@@ -474,6 +474,7 @@ In the following section you find all available cops:
 * xref:cops_style.adoc#styleproc[Style/Proc]
 * xref:cops_style.adoc#styleraiseargs[Style/RaiseArgs]
 * xref:cops_style.adoc#stylerandomwithoffset[Style/RandomWithOffset]
+* xref:cops_style.adoc#styleredundantargument[Style/RedundantArgument]
 * xref:cops_style.adoc#styleredundantassignment[Style/RedundantAssignment]
 * xref:cops_style.adoc#styleredundantbegin[Style/RedundantBegin]
 * xref:cops_style.adoc#styleredundantcapitalw[Style/RedundantCapitalW]

docs/modules/ROOT/pages/cops_layout.adoc

@@ -1392,7 +1392,7 @@ end
 | Yes
 | Yes
 | 0.49
-| -
+| 1.4
 |===
 
 This cop checks whether method definitions are
@@ -1407,8 +1407,12 @@ one-line method definitions are considered an offense.
 
 === Examples
 
+==== EmptyLineBetweenMethodDefs: true (default)
+
 [source,ruby]
 ----
+# checks for empty lines between method definitions.
+
 # bad
 def a
 end
@@ -1426,11 +1430,79 @@ def b
 end
 ----
 
+==== EmptyLineBetweenClassDefs: true (default)
+
+[source,ruby]
+----
+# checks for empty lines between class definitions.
+
+# bad
+class A
+end
+class B
+end
+def b
+end
+----
+
+[source,ruby]
+----
+# good
+class A
+end
+
+class B
+end
+
+def b
+end
+----
+
+==== EmptyLineBetweenModuleDefs: true (default)
+
+[source,ruby]
+----
+# checks for empty lines between module definitions.
+
+# bad
+module A
+end
+module B
+end
+def b
+end
+----
+
+[source,ruby]
+----
+# good
+module A
+end
+
+module B
+end
+
+def b
+end
+----
+
 === Configurable attributes
 
 |===
 | Name | Default value | Configurable values
 
+| EmptyLineBetweenMethodDefs
+| `true`
+| Boolean
+
+| EmptyLineBetweenClassDefs
+| `true`
+| Boolean
+
+| EmptyLineBetweenModuleDefs
+| `true`
+| Boolean
+
 | AllowAdjacentOneLineDefs
 | `false`
 | Boolean
@@ -3792,7 +3864,7 @@ end
 | Yes
 | Yes
 | 0.25
-| 1.3
+| 1.4
 |===
 
 This cop checks the length of lines in the source code.
@@ -3858,7 +3930,7 @@ bar: "0000000000", baz: "0000000000"}
 | Name | Default value | Configurable values
 
 | AutoCorrect
-| `false`
+| `true`
 | Boolean
 
 | Max

docs/modules/ROOT/pages/cops_lint.adoc

@@ -2489,12 +2489,17 @@ x += 1
 | Yes
 | No
 | 0.89
-| -
+| 1.4
 |===
 
 This cop checks for the presence of constructors and lifecycle callbacks
 without calls to `super`.
 
+This cop does not consider `method_missing` (and `respond_to_missing?`)
+because in some cases it makes sense to overtake what is considered a
+missing method. In other cases, the theoretical ideal handling could be
+challenging or verbose for no actual gain.
+
 === Examples
 
 [source,ruby]
@@ -4696,6 +4701,9 @@ values.reduce(nil) do |result, value|
   value
 end
 
+# good, recursive
+keys.reduce(self) { |result, key| result[key] }
+
 # ignored as the return value cannot be determined
 enum.reduce do |acc, el|
   x = foo(acc, el)

docs/modules/ROOT/pages/cops_style.adoc

@@ -2393,6 +2393,11 @@ end
   module Namespace
     Public = Class.new
   end
+
+  # Macro calls
+  module Namespace
+    extend Foo
+  end
 ----
 
 === Configurable attributes
@@ -7883,6 +7888,64 @@ rand(1...7)
 
 * https://rubystyle.guide#random-numbers
 
+== Style/RedundantArgument
+
+|===
+| Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+
+| Pending
+| No
+| No
+| 1.4
+| -
+|===
+
+This cop checks for a redundant argument passed to certain methods.
+
+Limitations:
+
+1. This cop matches for method names only and hence cannot tell apart
+   methods with same name in different classes.
+2. This cop is limited to methods with single parameter.
+3. This cop is unsafe if certain special global variables (e.g. `$;`) are set.
+   That depends on the nature of the target methods, of course.
+
+Method names and their redundant arguments can be configured like this:
+
+Methods:
+  join: ''
+  split: ' '
+  foo: 2
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+array.join('')
+[1, 2, 3].join("")
+string.split(" ")
+"first\nsecond".split(" ")
+A.foo(2)
+
+# good
+array.join
+[1, 2, 3].join
+string.split
+"first second".split
+A.foo
+----
+
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| Methods
+| `{"join"=>"", "split"=>" "}`
+| 
+|===
+
 == Style/RedundantAssignment
 
 |===

docs/modules/ROOT/pages/installation.adoc

@@ -22,7 +22,7 @@ in your `Gemfile`:
 
 [source,rb]
 ----
-gem 'rubocop', '~> 1.3', require: false
+gem 'rubocop', '~> 1.4', require: false
 ----
 
 NOTE: You can check out our progress on the road to version 1.0 https://github.com/rubocop-hq/rubocop/milestone/4[here].

lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.3.1'
+    STRING = '1.4.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, '\
           'rubocop-ast %<rubocop_ast_version>s, ' \

relnotes/v1.4.0.md

@@ -0,0 +1,34 @@
+### New features
+
+* [#7737](https://github.com/rubocop-hq/rubocop/issues/7737): Add new `Style/RedundantArgument` cop. ([@tejasbubane][])
+* [#9064](https://github.com/rubocop-hq/rubocop/issues/9064): Add `EmptyLineBetweenMethodDefs`, `EmptyLineBetweenClassDefs` and `EmptyLineBetweenModuleDefs` config options for `Layout/EmptyLineBetweenDefs` cop. ([@tejasbubane][])
+* [#9043](https://github.com/rubocop-hq/rubocop/pull/9043): Add `--stderr` to write all output to stderr except for the autocorrected source. ([@knu][])
+
+### Bug fixes
+
+* [#9067](https://github.com/rubocop-hq/rubocop/pull/9067): Fix an incorrect auto-correct for `Lint::AmbiguousRegexpLiteral` when passing in a regexp to a method with no receiver. ([@amatsuda][])
+* [#9060](https://github.com/rubocop-hq/rubocop/issues/9060): Fix an error for `Layout/SpaceAroundMethodCallOperator` when using `__ENCODING__`. ([@koic][])
+* [#7338](https://github.com/rubocop-hq/rubocop/issues/7338): Handle assignment with `[]=` in `MultilineMethodCallIndentation`. ([@jonas054][])
+
+* [#7726](https://github.com/rubocop-hq/rubocop/issues/7726): Fix `MultilineMethodCallIndentation` indentation inside square brackets. ([@jonas054][])
+* [#8857](https://github.com/rubocop-hq/rubocop/issues/8857): Improve how `Exclude` properties are generated by `--auto-gen-config`. ([@jonas054][])
+
+### Changes
+
+* [#8788](https://github.com/rubocop-hq/rubocop/issues/8788): Change `Style/Documentation` to not trigger offense with only macros. ([@tejasbubane][])
+* [#8993](https://github.com/rubocop-hq/rubocop/issues/8993): Allow `ExcludedMethods` config of `Metrics/MethodLength` cop to contain regex. ([@tejasbubane][])
+* [#9073](https://github.com/rubocop-hq/rubocop/issues/9073): Enable `Layout/LineLength`'s auto-correct by default. ([@bbatsov][])
+* [#9079](https://github.com/rubocop-hq/rubocop/pull/9079): Improve the gemspec to load only the necessary files without the git utility. ([@piotrmurach][])
+* [#9059](https://github.com/rubocop-hq/rubocop/pull/9059): Update `Lint/UnmodifiedReduceAccumulator` to accept blocks which return in the form `accumulator[element]`. ([@dvandersluis][])
+* [#9072](https://github.com/rubocop-hq/rubocop/pull/9072): `Lint/MissingSuper`: exclude `method_missing` and `respond_to_missing?`. ([@marcandre][])
+* [#9074](https://github.com/rubocop-hq/rubocop/pull/9074): Allow specifying a pull request ID when calling `rake changelog:*`. ([@marcandre][])
+
+[@tejasbubane]: https://github.com/tejasbubane
+[@knu]: https://github.com/knu
+[@amatsuda]: https://github.com/amatsuda
+[@koic]: https://github.com/koic
+[@jonas054]: https://github.com/jonas054
+[@bbatsov]: https://github.com/bbatsov
+[@piotrmurach]: https://github.com/piotrmurach
+[@dvandersluis]: https://github.com/dvandersluis
+[@marcandre]: https://github.com/marcandre