This repository was archived by the owner on Aug 4, 2019. It is now read-only.
Update to latest toxAV from mannol #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated the callback for video and audio bitrate. Update tests so they work with new toxav
| - (void) toxAV:(OCTToxAV *)toxAV bitrateStatusForFriendNumber:(OCTToxFriendNumber)friendNumber | ||
| audioBitRate:(OCTToxAVAudioBitRate)audioBitrate | ||
| videoBitRate:(OCTToxAVVideoBitRate)videoBitrate | ||
| {} |
There was a problem hiding this comment.
Why objcTox isn't handling this callback?
There was a problem hiding this comment.
Yea you are right, this should be done at objcTox level. I'll move this.
There was a problem hiding this comment.
Hm... I think that it should be done not in OCTToxAV, but on more higher level. OCTSubmanagerCalls would be perfect place for that. So everything was fine, no need to remove the callback. I was just writing about those empty parentheses.
Can you please get it back (and add a comment to the #88 here)? :-)
Sorry for confusing.
I'll take a look. Created an issue #144 |
|
Cool, thanks! |
dvor
added a commit
that referenced
this pull request
Oct 18, 2015
…udio Update to latest toxAV from mannol
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new enums were added from toxav.
Did
$ xctool -workspace objcTox.xcworkspace -scheme iOSDemo -sdk iphonesimulator CODE_SIGNING_REQUIRED=NO GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES clean testBut got one error:
Unable to read build settings for target 'iOSDemoTests'. It's likely that the scheme references a non-existent target.xcodebuild: error: The test action requires that the name of a scheme in the project is provided using the "-scheme" option. The "-list" option can be used to find the names of the schemes in the project.However all tests pass when running them in xcode