Automatically create topic for dead letters if it does not exist #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolang
reviewed
Mar 22, 2024
zio-gc-pubsub-google/src/main/scala/com/anymindgroup/pubsub/google/SubscriptionAdmin.scala
Outdated
Show resolved
Hide resolved
zio-gc-pubsub-google/src/main/scala/com/anymindgroup/pubsub/google/SubscriptionAdmin.scala
Outdated
Show resolved
Hide resolved
…sub subscriptions
dutch3883
force-pushed
the
9-extend-admin-clients-to-updatesync-topics-and-subscriptions-based-on-configuration
branch
2 times, most recently
from
e73efc3 to
a0c2d6d
Compare
…sub subscriptions > update as review
dutch3883
force-pushed
the
9-extend-admin-clients-to-updatesync-topics-and-subscriptions-based-on-configuration
branch
2 times, most recently
from
001fbd0 to
610ef01
Compare
dutch3883
force-pushed
the
9-extend-admin-clients-to-updatesync-topics-and-subscriptions-based-on-configuration
branch
from
610ef01 to
2132e5c
Compare
rolang
approved these changes
Apr 1, 2024
| emulatorConnectionConfigLayer() | ||
| ), | ||
| }.provideSome[Scope](emulatorConnectionConfigLayer()), | ||
| test("Subscription without dead letters policy should be updated if when already exist") { |
There was a problem hiding this comment.
"if when already exist" => "if already exists"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.