-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] - Accept all file types #123
Comments
The app imports by mime type, not by extension:
I guess I can add a way to import other file types as well, but then it would not only be a gallery app. |
Ah, that makes more sense, I was going off of this file: Valv-Android/app/src/main/java/se/arctosoft/vault/data/FileType.java Lines 25 to 72 in e4aafe8
Seems like text support is already implemented? But importing is still limited to Valv-Android/app/src/main/java/se/arctosoft/vault/encryption/Encryption.java Lines 103 to 115 in e4aafe8
A more separate approach where, everything can be imported and encrypted, and certain files can then be opened/viewed in the vault, would make more sense to me. (I'm also just a user and haven't looked at the code much) |
Is your feature request related to a problem? Please describe.
Currently only specific file types are allowed to be encrypted. This is determined by their file name extension. I don't see any reason for that. File types should be determined by their contents, instead of their names. Even if they are unsupported they should still be encryptable. Support for audio only files (mp3, aac. etc.) for example is trivial via the video viewer.
Describe the solution you'd like
All files should be encryptable.
Files with unknown extensions should trigger a prompt on how to open them (Image, Video, Text, etc.)
All other files should also have the opportunity to be opened in the other modes.
Additional context
Every other filesystem/application does it that way, you can rename an image to
image.pdf
and still open it with an image viewer.The text was updated successfully, but these errors were encountered: