Skip to content

AP_HAL_ChibiOS: add hwdef files for NarinFC-H5 #29753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

vololand
Copy link
Contributor

AP_HAL_ChibiOS: add hwdef files for NarinFC-H5

vololand and others added 2 commits April 18, 2025 17:36
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Apr 18, 2025

@vololand since this is just a minor change to the H7, it should be done via includes...which I have provided new hwdefs...I built a new bootloader with the new board id (you had the H7 one), changed the bd id, since it was already taken....

as to the wiki page, it should just be included on the H7 page as a variant.

the big problem is the name...STM32-Hxxx is a valid processor series...naming it an -H5 is misleading and will cause confusion....
its your product, it will cause questions however....the pattern with other autopilots is to use something like Narin-H7A,etc.
not sure if this will be an issue when Dev team considers this PR

@Hwurzburg Hwurzburg requested a review from andyp1per April 18, 2025 23:43
  - ICM45686 SPI MAX SPEED UPDATE.(8*MHZ -> 16*MHZ)
@vololand
Copy link
Contributor Author

vololand commented Apr 21, 2025

@vololand since this is just a minor change to the H7, it should be done via includes...which I have provided new hwdefs...I built a new bootloader with the new board id (you had the H7 one), changed the bd id, since it was already taken....

as to the wiki page, it should just be included on the H7 page as a variant.

the big problem is the name...STM32-Hxxx is a valid processor series...naming it an -H5 is misleading and will cause confusion.... its your product, it will cause questions however....the pattern with other autopilots is to use something like Narin-H7A,etc. not sure if this will be an issue when Dev team considers this PR

@Hwurzburg
I checked in update hwdef.dat.
I will add the content of NarinFC-H5 to the NarinFC-H7 page.
Thank you for your advice.

@peterbarker
Copy link
Contributor

@vololand are you absolutely sure that you want to call this a "H5"? This might turn consumers off as they want a H7 processor and would consider a "H5" to be a "lesser device" than a H7. The fact it's running a H7 processor will be completely lost!

Please confirm you really want to use "H5" - everyone on the DevCall I'm currently on thinks its a bad name!

@rmackay9
Copy link
Contributor

We decided to hold off on merging this for another week in order to revisit the name again.

@vololand
Copy link
Contributor Author

@vololand are you absolutely sure that you want to call this a "H5"? This might turn consumers off as they want a H7 processor and would consider a "H5" to be a "lesser device" than a H7. The fact it's running a H7 processor will be completely lost!

Please confirm you really want to use "H5" - everyone on the DevCall I'm currently on thinks its a bad name!

@peterbarker
Thank you for your feedback.
I fully understand your concern.
I will use NarinFC-H5 as it is.
Thank you.

@vololand
Copy link
Contributor Author

We decided to hold off on merging this for another week in order to revisit the name again.

@rmackay9
Thank you for your consideration.
I fully understand your concern.
I hope it will be merged as soon as possible.
Thank you.

@peterbarker peterbarker merged commit 5f0c266 into ArduPilot:master Apr 29, 2025
53 checks passed
@peterbarker
Copy link
Contributor

Merged it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants