Fixup lua language server CI #29889
Fixup lua language server CI #29889
Conversation
|
@stephendade FYI |
| @@ -760,7 +760,7 @@ function HLSatcom() | |||
| --- check if GCS telemetry has been lost for RCK_TIMEOUT sec (if param enabled) | |||
| if RCK_FORCEHL:get() == 2 then | |||
| -- link lost time = boot time - GCS last seen time | |||
| link_lost_for = millis():toint() - gcs:last_seen() | |||
| link_lost_for = (millis()- gcs:last_seen()):toint() | |||
There was a problem hiding this comment.
The subtraction was casting back to a uint32 so the result was not a int.
I'll run some checks in the next day or two and confirm the changes are OK (they most likely are) |
|
Bumped off DevCallTopic so @stephendade can run his tests. Please ping once you're done, @stephendade :-) |
I could alternately add a error ignore for just that file, then Stephen can take his time. |
IamPete1
force-pushed
the
lualanguageServerCI
branch
from
e157737 to
316d764
Compare
I did that. |
|
@stephendade could you test the original PR to make sure it works, or create a patch which grabs the changes from the original PR and removes the new ignore lines, please? |
Sure. I've now had a chance to test @IamPete1's original changes, and they worked fine, so I'll create a new PR to re-include them |
Our lua language server CI has been incorrectly passing thanks to some recent changes to the language server. This updates so it correctly fails (and fixes the issues that crept in)
I can't get the problem matcher to work again, so no nice annotations,
fileLocationseems to not work. It works fine for the luacheck problem matcher, so I have no idea.A alternate fix would be to add
--check_format jsonto the call to the language server. But the new native error printing is nicer than what I had done in python by parsing the json. Just we loose the problem match.