-
Notifications
You must be signed in to change notification settings - Fork 18.7k
added radian f4 and h7 hardware definitions #30053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to configure and build as a starting point :-)
@@ -0,0 +1,2 @@ | |||
# Setup default params | |||
LOG_FILE_BUFSIZE 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the default anyway?
needs readme....see https://ardupilot.org/dev/docs/readme_file.html#readme-file for requirements |
Added README.md for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Needs board id assigned in board_types.txt....use a separate PR....then use the NAME not number for board id in hwdef files
-Split the F405 stuff out separately from this PR....its not on your website yet and I cant even do a prelim review...it will hold the H7 up
-Your website does NOT list all the board connector's pinoouts...before a final approve, I will need to see those
|
||
--- | ||
|
||
## UART Port Mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this table is wrong...and does not list the corresponding UART/USART....and does not mention each UARTs DMA capability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UART5 RX does NOT have DMA since its an ALT config...
I suggest dropping using the timer input (sacrificing PPM), rename the PPM_IN pin to RCIN....drop the UART alt config sets protocol to RC in with define DEFAULT_SERIAL7_PROTOCOL SerialProtocol_RCIN ....UART5 will get full DMA then also
- **Carrier board:** 46 × 38 mm (M4 mounting holes for M3 dampers, 30.5 × 30.5 mm spacing) | ||
- **Radian core module:** 32 × 32 mm (M2 mounting holes with integrated standoffs) | ||
|
||
<img src="https://aerium.bitbucket.io/documentation/assets/images/radian-dimensions-3eba0ff37b66f5fc1343267414ca2eb3.jpg#diagram" width="35%" alt="Radian Dimensions"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally we include all image files in this directory...saves me time when making the wiki page
|
||
## PWM / Servo Outputs | ||
|
||
- Provides 8 independent PWM or servo outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect format/content: see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7-Wing/README.md for an example
|
||
--- | ||
|
||
## RC Input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your hwdef has RC in on the PPM_IN, and it only supports unidirectional RC protocols. You don't mention that its the UART5 in pin, you don't mention the ALT config...or that bi-directional RC needs a full UART and CRSF/ELRS needs RX DMA (hence the need for its listing in the UART section)
see below
|
||
## RC Input | ||
|
||
- Supports PPM-Sum, S.Bus, and iBUS protocols via the RC input port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace all these lines with this if you follow my suggestion on using UART5 for RC all time
- Supports PPM-Sum, S.Bus, and iBUS protocols via the RC input port | |
- RCinput is on the RC_IN pin which is ties to the UART5 RX pin. It supports all ArduPilot compatible uni-directional protocols. For bi-directional protocols such as CSRF the UART5 connector (where is it???) can be used. See :ref:`common-rc-systems` for details. | |
|
||
--- | ||
|
||
## Power & Battery Monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect format, see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/README.md (raw view) for an example
- Use onboard VSense jumpers to toggle between internal and external sensing for each input | ||
- Voltage and current scalers can be adjusted for precise measurements | ||
|
||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs an RSSI section, AIRSPEED section
see https://ardupilot.org/copter/docs/common-aocoda-h743dual.html for an example
@Hwurzburg, the F405 is the one listed on the website. I have pushed fixes to the F405 README according to the comments you made on the H743. Added PR for board IDs |
sounds good, will review tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need a change to Tools/AP_Bootloaders/board_types.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR needs a fair bit of rework. We also need to squash and split the commits as per our coding guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more review comments...marking as WIP due to level of changes needed
- Additional receiver types can be connected via configurable serial ports | ||
- For setup instructions, consult the [ArduPilot RC systems guide](https://ardupilot.org/copter/docs/common-rc-systems.html) | ||
|
||
## Power supply & Battery Monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BAttery Monitor defaults need to be noted....see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/ATOMRCF405NAVI-Deluxe/README.md for an example
also you did not add a define in the hwdef to enable the first monitor
BARO BMP280 SPI:bmp280 | ||
BARO LPS2XH SPI:lps22h | ||
|
||
# define default battery setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first monitot NOT enabled...needs the define
also the scales are not really "1" are they?
@Hwurzburg, @tridge and @peterbarker Please review it at your convenience. |
Added Aerium Radian F4/H7 HW definitions
https://www.aerium.co.il/product-page/radian
Test coverage
Full compilation
HW flashing
Sensor calibration and testing
Interface Testing
Manual and automatic test flights