Skip to content

added radian f4 and h7 hardware definitions #30053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

yaadch
Copy link

@yaadch yaadch commented May 12, 2025

Added Aerium Radian F4/H7 HW definitions
https://www.aerium.co.il/product-page/radian

Test coverage
Full compilation
HW flashing
Sensor calibration and testing
Interface Testing
Manual and automatic test flights

image

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to configure and build as a starting point :-)

@@ -0,0 +1,2 @@
# Setup default params
LOG_FILE_BUFSIZE 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the default anyway?

@yaadch yaadch requested a review from peterbarker May 13, 2025 06:26
@Hwurzburg Hwurzburg requested review from andyp1per and Hwurzburg May 13, 2025 14:33
@Hwurzburg
Copy link
Contributor

needs readme....see https://ardupilot.org/dev/docs/readme_file.html#readme-file for requirements

@yaadch
Copy link
Author

yaadch commented May 18, 2025

Added README.md for both

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Needs board id assigned in board_types.txt....use a separate PR....then use the NAME not number for board id in hwdef files
-Split the F405 stuff out separately from this PR....its not on your website yet and I cant even do a prelim review...it will hold the H7 up
-Your website does NOT list all the board connector's pinoouts...before a final approve, I will need to see those


---

## UART Port Mapping
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this table is wrong...and does not list the corresponding UART/USART....and does not mention each UARTs DMA capability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UART5 RX does NOT have DMA since its an ALT config...
I suggest dropping using the timer input (sacrificing PPM), rename the PPM_IN pin to RCIN....drop the UART alt config sets protocol to RC in with define DEFAULT_SERIAL7_PROTOCOL SerialProtocol_RCIN ....UART5 will get full DMA then also

- **Carrier board:** 46 × 38 mm (M4 mounting holes for M3 dampers, 30.5 × 30.5 mm spacing)
- **Radian core module:** 32 × 32 mm (M2 mounting holes with integrated standoffs)

<img src="https://aerium.bitbucket.io/documentation/assets/images/radian-dimensions-3eba0ff37b66f5fc1343267414ca2eb3.jpg#diagram" width="35%" alt="Radian Dimensions">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally we include all image files in this directory...saves me time when making the wiki page


## PWM / Servo Outputs

- Provides 8 independent PWM or servo outputs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


---

## RC Input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your hwdef has RC in on the PPM_IN, and it only supports unidirectional RC protocols. You don't mention that its the UART5 in pin, you don't mention the ALT config...or that bi-directional RC needs a full UART and CRSF/ELRS needs RX DMA (hence the need for its listing in the UART section)
see below


## RC Input

- Supports PPM-Sum, S.Bus, and iBUS protocols via the RC input port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace all these lines with this if you follow my suggestion on using UART5 for RC all time

Suggested change
- Supports PPM-Sum, S.Bus, and iBUS protocols via the RC input port
- RCinput is on the RC_IN pin which is ties to the UART5 RX pin. It supports all ArduPilot compatible uni-directional protocols. For bi-directional protocols such as CSRF the UART5 connector (where is it???) can be used. See :ref:`common-rc-systems` for details.


---

## Power & Battery Monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Use onboard VSense jumpers to toggle between internal and external sensing for each input
- Voltage and current scalers can be adjusted for precise measurements

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an RSSI section, AIRSPEED section
see https://ardupilot.org/copter/docs/common-aocoda-h743dual.html for an example

@yaadch
Copy link
Author

yaadch commented May 19, 2025

@Hwurzburg, the F405 is the one listed on the website.
Both modules connect to the same carrier board (which doesn't utilize all FCUs pins and ports) so it might be a bit confusing.
How about I'll drop the H743 from this PR and open a new PR for it for better separation.
Assuming you agree to focus on the F405, anything else you would like me to add / edit?

I have pushed fixes to the F405 README according to the comments you made on the H743.
The full pinout documentation and pinout exists here: https://aerium.bitbucket.io/documentation/Product%20Manuals/Radian/
For better clarity, I have fixed to images to include the pinout as well.

Added PR for board IDs
#30114

@Hwurzburg
Copy link
Contributor

sounds good, will review tomorrow

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label May 20, 2025
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a change to Tools/AP_Bootloaders/board_types.txt

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR needs a fair bit of rework. We also need to squash and split the commits as per our coding guide

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more review comments...marking as WIP due to level of changes needed

- Additional receiver types can be connected via configurable serial ports
- For setup instructions, consult the [ArduPilot RC systems guide](https://ardupilot.org/copter/docs/common-rc-systems.html)

## Power supply & Battery Monitoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAttery Monitor defaults need to be noted....see https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/ATOMRCF405NAVI-Deluxe/README.md for an example
also you did not add a define in the hwdef to enable the first monitor

BARO BMP280 SPI:bmp280
BARO LPS2XH SPI:lps22h

# define default battery setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first monitot NOT enabled...needs the define
also the scales are not really "1" are they?

@Hwurzburg Hwurzburg added the WIP label May 22, 2025
@yaadch
Copy link
Author

yaadch commented May 28, 2025

@Hwurzburg, @tridge and @peterbarker
I believe I've made the necessary changes based on your comments.
It now compiles for the plane as well.

Please review it at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants