-
Notifications
You must be signed in to change notification settings - Fork 18.8k
AP_Scheduler: fixed Example code not working by adding ins.update() #30154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@peterbarker I have tested the code. It's finished. I don't know how to resolve failing checks. Could you guide me please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dinhthong,
Since PeterB's approval it looks like a Merge commit has been added. Could you rebase this on master to remove that commit?
I have rebased my commits to master on my Fork. |
As discussed in Discord, maybe try these steps: First update your "master" branch to match ardupilot's master branch:
Next rebase your Sche_Test branch off of "master":
|
@rmackay9 Thanks for the detailed guide. In step 5 of "update your master branch to match ArduPilot's master branch" I had to use git push --force instead of git push as it was rejected without --force. |
Co-authored-by: Peter Barker <pb-gh@barker.dropbear.id.au>
add confidence threshold definition remove unused definitions
@peterbarker I have made the necessary update. Could you review my change? |
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
these often make their way in when moving from some other printf-style debugging...
returns get_velocity_NED.z if available otherwise falls back to get_vert_pos_rate_D
Co-authored-by: Randy Mackay <rmackay9@yahoo.com>
the specs were preventing cacheing
The example seems to be failing again in here somehow - could you check, please? |
…the unsigned type
The original AP_Scheduler example sketch doesn't work as expected
After debugging I found that: The AP_Scheduler library requires ins.update() else it would be stuck in the scheduler.loop();