Skip to content

AC_AttitudeControl use const where possible #30165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lthall
Copy link
Contributor

@lthall lthall commented May 25, 2025

This is addressing the feedback that I have missed a number of locations where I should be using const.

Intended to go in after #30164

Board,blimp,bootloader,copter,heli,plane,rover,sub
CubeOrange,*,*,*,*,*,*,*

@peterbarker
Copy link
Contributor

Conflicting now.

I was going to do that as part of the PR I just merged but didn't want to introduce merge conflicts with your other PR.

... I was going to suggest const on that other PR where we are modifying these lines anyway to change radians(ang)*0.01 to ang*radians(0.01)

@lthall lthall force-pushed the 20250525_AC_AttitudeControl_Use_Const branch 2 times, most recently from 4e9b2da to 883c6af Compare May 26, 2025 03:53
@lthall lthall force-pushed the 20250525_AC_AttitudeControl_Use_Const branch from 883c6af to bbace67 Compare May 26, 2025 08:01
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@peterbarker
Copy link
Contributor

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                 *                                                   
CubeRedPrimary                      *      *           *       *                 *      *      *
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                 *                                                   
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                 *                                                   
f303-Universal           *                 *                                                   
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-journey                                       *                                       
skyviper-v2450                                         *                                       

@peterbarker peterbarker merged commit 758bf12 into ArduPilot:master May 26, 2025
140 of 146 checks passed
@lthall lthall deleted the 20250525_AC_AttitudeControl_Use_Const branch May 27, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants