Sub: correct setting of MAV_SYS_STATUS_SENSOR_ABSOLUTE_PRESSURE #30169
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs @Williangalvani to approve |
Williangalvani
requested changes
May 28, 2025
ArduSub/GCS_Sub.cpp
Outdated
| @@ -41,14 +41,16 @@ void GCS_Sub::update_vehicle_sensor_status_flags() | |||
| } | |||
|
|
|||
| // override the parent class's values for ABSOLUTE_PRESSURE to | |||
| // only check internal barometer: | |||
| // only honour water-pressure sensors | |||
| control_sensors_present &= ~MAV_SYS_STATUS_SENSOR_ABSOLUTE_PRESSURE; // check the internal barometer only | |||
There was a problem hiding this comment.
Suggested change
| control_sensors_present &= ~MAV_SYS_STATUS_SENSOR_ABSOLUTE_PRESSURE; // check the internal barometer only | |
| control_sensors_present &= ~MAV_SYS_STATUS_SENSOR_ABSOLUTE_PRESSURE; |
we only want to be present and enabled if there is actually a depth sensor on board. Otherwise we can be present and enabled but never healthy when we don't have a depth sensor
peterbarker
force-pushed
the
pr/sub-pressure-sensor-fix
branch
from
c990351 to
3389075
Compare
Williangalvani
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only want to be present and enabled if there is actually a depth sensor on board. Otherwise we can be present and enabled but never healthy when we don't have a depth sensor