create and use AP_AHRS::has_status #30175
Draft
+51
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
May 27, 2025
peterbarker
force-pushed
the
pr/ahrs-has-status
branch
from
d5e774c to
47c2568
Compare
|
This looks pretty good to me |
| @@ -51,6 +51,33 @@ class AP_AHRS { | |||
| FLAG_ALWAYS_USE_EKF = 0x1, | |||
| }; | |||
|
|
|||
| // enumeration corresponding to buts within nav_filter_status union. | |||
There was a problem hiding this comment.
Suggested change
| // enumeration corresponding to buts within nav_filter_status union. | |
| // enumeration corresponding to bits within nav_filter_status union. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently just the shape I am intending.
Not sure about the boolean return value on get-filter-status. I think we just make the get_filter_status non-boolean and the backends must make a best-effort to fill in