AP_DDS: Fixing scope errors that prevent colcon build of ardupilot_dds_tests

[mueller-lukas]

This pull request fixes scope issues in the AP_DDS_Client.cpp file by adding Status:: and other necessary scope resolutions. The initial colcon compile error was:

../../libraries/AP_DDS/AP_DDS_Client.cpp: In member function ‘void AP_DDS_Client::on_request(uxrSession*, uxrObjectId, uint16_t, SampleIdentity*, ucdrBuffer*, uint16_t)’:
../../libraries/AP_DDS/AP_DDS_Client.cpp:1185:58: error: ‘PARAMETER_NOT_SET’ was not declared in this scope; did you mean ‘ParameterType::PARAMETER_NOT_SET’?
 1185 |                 get_parameters_response.values[i].type = PARAMETER_NOT_SET;
      |                                                          ^~~~~~~~~~~~~~~~~
      |                                                          ParameterType::PARAMETER_NOT_SET
compilation terminated due to -Wfatal-errors.

Waf: Leaving directory `/home/hiwi/ardu_ws/src/ardupilot/build/sitl'
Build failed

[peterbarker]

Please remove the (fix) bit from the commit message

[snktshrma]

Hi @mueller-lukas ! Seems like a duplicate to #29850
We are resolving issues with CI for updated Micro-XRCE-DDS-Gen and once that's sorted, we'll merge the changes

[mueller-lukas]

Hi @mueller-lukas ! Seems like a duplicate to #29850 We are resolving issues with CI for updated Micro-XRCE-DDS-Gen and once that's sorted, we'll merge the changes

Thank you for your quick response. It appears that this issue is indeed a duplicate of #29850.

Is there an estimated timeline for the resolution, as the installation based on ROS 2 with SITL in Gazebo is broken because of this issue.

[snktshrma]

@mueller-lukas For now, if you need to proceed with the build, use this specific state of the XRCE DDS Gen:
https://github.com/ArduPilot/Micro-XRCE-DDS-Gen/tree/93b118a27758eea5cddf14baa17bfcaaaa69dcff
This is an older, stable version and does not include the latest two commits, which are currently causing issues in the generation process.

Or you can continue with the scope resolution additions you did to the AP and use latest Micro-XRCE-DDS-Gen as you are doing until this CI issue is resolved.