Skip to content

ftxui::Element Render with FTXUI 6.x #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barracuda156 opened this issue May 27, 2025 · 4 comments
Closed

ftxui::Element Render with FTXUI 6.x #1049

barracuda156 opened this issue May 27, 2025 · 4 comments

Comments

@barracuda156
Copy link

@ArthurSonzogni After b0e087e should the code which assumes FTXUI 5.x be using OnRender in place of Render?
just-fast fails to compile with 6.x, complaining that ftxui::Element JustFastUi::Render() is marked override, but does not override.
The header in just-fast has ftxui::Element Render() override;.

@ArthurSonzogni
Copy link
Owner

Hello @barracuda156 arracuda156
OnRender is now the one to be overridden instead.

@barracuda156
Copy link
Author

@ArthurSonzogni Thank you. So just to confirm, just replacing instances of Render with OnRender should do? I did that in https://github.com/macos-powerpc/powerpc-ports/blob/5aa52821d262f5b16bb83031dcc41c077ba33d99/sysutils/just-fast/files/patch-ftxui-render.diff and it seems to work (build succeeds and the app works, apparently).

@ArthurSonzogni
Copy link
Owner

Yes, I confirm.

@barracuda156
Copy link
Author

Thank you! I close this as resolved then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants