Additional checks

Author: Dinonard

pallets/dapps-staking/src/pallet/mod.rs

@@ -310,6 +310,8 @@ pub mod pallet {
         NominationTransferToSameContract,
         /// Decommission is in progress so this call is not allowed.
         DecommissionInProgress,
+        /// Delegated claim call is not allowed if both the staker & caller are the same accounts.
+        ClaimForCallerAccount,
     }
 
     #[pallet::hooks]
@@ -930,6 +932,8 @@ pub mod pallet {
             Self::ensure_pallet_enabled()?;
             let caller = ensure_signed(origin)?;
 
+            ensure!(caller != staker, Error::<T>::ClaimForCallerAccount);
+
             Self::internal_claim_staker_for(caller, staker, contract_id, true)
         }
 

pallets/dapps-staking/src/tests.rs

@@ -2550,6 +2550,32 @@ fn claim_staker_for_works() {
     })
 }
 
+#[test]
+fn claim_staker_for_fails_if_caller_is_same_as_staker() {
+    ExternalityBuilder::build().execute_with(|| {
+        initialize_first_block();
+
+        // Register a dApp and stake some amount on it
+        let developer = 1;
+        let staker = 2;
+        let smart_contract = MockSmartContract::Evm(H160::repeat_byte(0x02));
+        assert_register(developer, &smart_contract);
+        assert_bond_and_stake(staker, &smart_contract, 13);
+
+        // Advance to next era so we can claim rewards for it
+        advance_to_era(DappsStaking::current_era() + 1);
+
+        assert_noop!(
+            DappsStaking::claim_staker_for(
+                RuntimeOrigin::signed(staker),
+                staker,
+                smart_contract.clone()
+            ),
+            Error::<TestRuntime>::ClaimForCallerAccount
+        );
+    })
+}
+
 #[test]
 fn set_reward_destination_for_works() {
     ExternalityBuilder::build().execute_with(|| {