Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-1301 release prep #1429

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

ipapandinas
Copy link
Contributor

Preparation for the runtime-1301 release.

@ipapandinas ipapandinas added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Feb 24, 2025
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/sr25519/src 56% 0%
pallets/collective-proxy/src 94% 0%
precompiles/dispatch-lockdrop/src 83% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/collator-selection/src 87% 0%
pallets/dapp-staking/src/benchmarking 95% 0%
pallets/vesting-mbm/src 87% 0%
primitives/src 54% 0%
pallets/unified-accounts/src 80% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
pallets/ethereum-checked/src 76% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/price-aggregator/src 76% 0%
precompiles/assets-erc20/src 78% 0%
precompiles/xcm/src 69% 0%
primitives/src/xcm 62% 0%
pallets/xc-asset-config/src 48% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/static-price-provider/src 91% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/dapp-staking/src 78% 0%
precompiles/substrate-ecdsa/src 67% 0%
chain-extensions/pallet-assets/src 54% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dynamic-evm-base-fee/src 82% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
chain-extensions/types/assets/src 0% 0%
pallets/inflation/src 90% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/dapp-staking/src 89% 0%
Summary 75% (3708 / 4928) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also clean up Shibuya migrations, but they shouldn't be executed given migration is versioned, right?

@ipapandinas
Copy link
Contributor Author

yes, it is versioned, it should not be executed, I keep an eye on the CI

@ipapandinas ipapandinas merged commit 09576d3 into master Feb 24, 2025
12 checks passed
@ipapandinas ipapandinas deleted the feat/runtime-1301-release-prep branch February 24, 2025 12:26
@ipapandinas
Copy link
Contributor Author

@Dinonard - FYI, extracted from the CI job logs

shibuya_runtime   INFO: try-runtime::on_runtime_upgrade
   frame_support::migrations   WARN: 🚚 Pallet "DappStaking" VersionedMigration migration 8->9 can be removed; on-chain is already at StorageVersion(9).

I will remove all migrations in the upcoming cleanup PR after release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants