Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch Lockdrop account - Precompile #1142
Dispatch Lockdrop account - Precompile #1142
Changes from 2 commits
a3cf9fe
9aae4ae
e9c0c8d
8179f1a
0b20d11
123c2b0
06ab9f5
8532480
eb0d085
f05afc8
b2989ef
a73eb88
299cfe3
85dd6d0
d6e38dc
ed2cea0
357cb16
304a56c
c625065
98ec7c9
c792797
3605e75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to cover this case in unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a tests for it. Using the same pubkey & AccountId as from old pallet eth-sig
Astar/pallets/custom-signatures/src/tests.rs
Line 267 in 9395ce0