Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable metadata hash #1300

Merged
merged 1 commit into from
Jul 16, 2024
Merged

disable metadata hash #1300

merged 1 commit into from
Jul 16, 2024

Conversation

ermalkaleci
Copy link
Member

Pull Request Summary

seems like backport polkadot-sdk-1.9 not working

@ermalkaleci ermalkaleci requested a review from Dinonard July 16, 2024 10:25
@ermalkaleci ermalkaleci added the runtime This PR/Issue is related to the topic “runtime”. label Jul 16, 2024
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should have also enabled it before for other builds?

Collator, evm-tracing.
Irrelevant now, but we should keep it in mind for the future.

@ermalkaleci ermalkaleci merged commit 150b11c into master Jul 16, 2024
8 of 9 checks passed
@ermalkaleci ermalkaleci deleted the fix/disable-metadata-hash branch July 16, 2024 10:32
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/ethereum-checked/src 79% 0%
precompiles/assets-erc20/src 78% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/unified-accounts/src 77% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/src 90% 0%
pallets/xc-asset-config/src 50% 0%
primitives/src 62% 0%
precompiles/dispatch-lockdrop/src 86% 0%
precompiles/sr25519/src 64% 0%
pallets/xvm/src 54% 0%
pallets/static-price-provider/src 52% 0%
pallets/inflation/src 86% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/xcm/src 71% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/collator-selection/src 92% 0%
pallets/collective-proxy/src 86% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/price-aggregator/src 75% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/xvm/src 73% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/dapp-staking-v3/src/test 0% 0%
primitives/src/xcm 65% 0%
Summary 76% (3706 / 4850) 0% (0 / 0)

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants