Skip to content

Commit 5cc0db7

Browse files
committed
finetune assertion and test
1 parent c3e9fa3 commit 5cc0db7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/EmailAssertions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public static function assertPlusAlias(string $expected, $actual): void
4646
{
4747
PHPUnit::assertIsString($actual);
4848
[$localPart] = explode('@', $actual, 2);
49-
[$mailbox, $alias] = explode('+', $localPart, 2);
49+
[, $alias] = explode('+', $localPart, 2);
5050
PHPUnit::assertSame($expected, $alias);
5151
}
5252
}

tests/EmailAssertionsTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public static function it_can_validate_local_part(): void
5151
public static function it_can_validate_plus_mailbox(): void
5252
{
5353
$mailbox = self::randomString();
54-
$alias = self::randomBool();
54+
$alias = self::randomString();
5555
$email = $mailbox.'+'.$alias.'@email.com';
5656

5757
EmailAssertions::assertPlusMailbox($mailbox, $email);
@@ -64,7 +64,7 @@ public static function it_can_validate_plus_mailbox(): void
6464
public static function it_can_validate_plus_alias(): void
6565
{
6666
$mailbox = self::randomString();
67-
$alias = self::randomBool();
67+
$alias = self::randomString();
6868
$email = $mailbox.'+'.$alias.'@email.com';
6969

7070
EmailAssertions::assertPlusAlias($alias, $email);

0 commit comments

Comments
 (0)