cas: add option for static .well-known #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbearcsiro
requested changes
Mar 5, 2025
| # If cas_oidc_well_known_static is set to true in an inventory, nginx will serve the response directly from a static file. | ||
| cas_oidc_well_known_static: false | ||
| # OICD scopes for CAS | ||
| cas_oidc_well_known_scopes: |
There was a problem hiding this comment.
- If we're defining a var for this, then the list at
cas.authn.oidc.discovery.scopesinapplication.ymlshould also use it. - This list is missing digivol/internal
| { | ||
| "issuer": "{{auth_cas_url}}/oidc", | ||
| "scopes_supported": [ | ||
| {% for ascope in cas_oidc_well_known_scopes %} |
There was a problem hiding this comment.
We should have an additional loop after this one for the cas_extra_scopes var
| "claim_types_supported": [ | ||
| "normal" | ||
| ], | ||
| "claims_supported": [ |
There was a problem hiding this comment.
This is fine but is technically derived from application config (the static app config that's built into the JAR). Something to keep in mind if the app config is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option for the /cas/oidc/.well-known file to be delivered as a static file by nginx, so that when the CAS app is down, .well-known is still available: this endpoint is required by apps using OIDC, and we've found that .well-known being unavailable can cause apps to fail to start.